Finish off #2046

hadley · hadley · commit 690fdb87ed8d · 2025-01-08T14:54:18.000-06:00
* Add news bullet
* Add explanatory comment
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,7 @@
 # testthat (development version)
 
+* Fixed an issue where `expect_no_error(1)` was failing (#2037).
+
 * Fixed an issue where calling `skip()` outside of an active test could
   cause an unexpected error (@kevinushey, #2039).
 
diff --git a/R/expect-no-condition.R b/R/expect-no-condition.R
@@ -98,6 +98,8 @@ expect_no_ <- function(base_class,
     try_fetch(
       {
         code
+        # We can't call succeed() here because that generates a condition
+        # that causes `expect_no_condition()` to always fail
         NULL
       },
       !!base_class := function(cnd) {

Original file line number	Diff line number	Diff line change
`@@ -98,6 +98,8 @@ expect_no_ <- function(base_class,`
`98`	`98`	`try_fetch(`
`99`	`99`	`{`
`100`	`100`	`code`
	`101`	`+ # We can't call succeed() here because that generates a condition`
	`102`	+ # that causes `expect_no_condition()` to always fail
`101`	`103`	`NULL`
`102`	`104`	`},`
`103`	`105`	`!!base_class := function(cnd) {`