Simplify logic

hadley · hadley · commit 69355ca7838c · 2025-07-29T11:54:48.000-05:00
diff --git a/R/expect-inheritance.R b/R/expect-inheritance.R
@@ -141,7 +141,7 @@ expect_s4_class <- function(object, class) {
   exp_lab <- format_class(class)
 
   if (identical(class, NA)) {
-    if (!(isS4(object) == !is.na(class))) {
+    if (isS4(object)) {
       msg <- sprintf("%s is an S4 object", act$lab)
       return(fail(msg))
     }

Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ expect_s4_class <- function(object, class) {`
`141`	`141`	`exp_lab <- format_class(class)`
`142`	`142`
`143`	`143`	`if (identical(class, NA)) {`
`144`		`- if (!(isS4(object) == !is.na(class))) {`
	`144`	`+ if (isS4(object)) {`
`145`	`145`	`msg <- sprintf("%s is an S4 object", act$lab)`
`146`	`146`	`return(fail(msg))`
`147`	`147`	`}`