Remove unused field; revert snapshot changes

Author: hadley

R/reporter-check.R

@@ -13,7 +13,6 @@ CheckReporter <- R6::R6Class(
     skips = NULL,
     warnings = NULL,
     n_ok = 0L,
-    has_snapshot_failure = FALSE,
 
     initialize = function(...) {
       self$capabilities$parallel_support <- TRUE

tests/testthat/test-snapshot-file.R

@@ -1,5 +1,5 @@
 test_that("expect_snapshot_file works", {
-  path <- write_tmp_lines(letters[-1])
+  path <- write_tmp_lines(letters)
   expect_snapshot_file(path, "foo.r", compare = compare_file_text)
 
   path <- withr::local_tempfile()

tests/testthat/test-snapshot.R

@@ -15,7 +15,7 @@ test_that("can snapshot everything", {
     print("1")
     message("2")
     warning("3")
-    stop("5")
+    stop("4")
   }
   expect_snapshot(f(), error = TRUE)
 })