fix failure messages for comparisons of negative numbers

Author: stibu81

R/expect-comparison.R

@@ -194,7 +194,7 @@ digits <- function(x) {
   if (length(x) == 0) {
     return(0)
   }
-  scale <- -log10(min(x))
+  scale <- -log10(min(abs(x)))
   if (scale <= 0) {
     0L
   } else {

tests/testthat/_snaps/expect-comparison.md

@@ -76,6 +76,16 @@
       ! Expected `x` < 10.
       Actual comparison: NA >= 10.0
 
+# comparisons with negative numbers work
+
+    Code
+      expect_gt(-5, -2)
+    Condition
+      Error:
+      ! Expected `-5` > `-2`.
+      Actual comparison: -5.0 <= -2.0
+      Difference: -3.0 <= 0
+
 # comparisons with POSIXct objects work
 
     Code

tests/testthat/test-expect-comparison.R

@@ -58,6 +58,12 @@ test_that("comparisons with NA work", {
   expect_snapshot_failure(expect_lt(x, 10))
 })
 
+
+test_that("comparisons with negative numbers work", {
+  expect_success(expect_lt(-5, -2))
+  expect_snapshot_failure(expect_gt(-5, -2))
+})
+
 test_that("comparisons with POSIXct objects work", {
   time <- as.POSIXct("2020-01-01 01:00:00")
   time2 <- time + 1.5