Correct implementation of expect_waldo_constant()

hadley · hadley · commit 8af3c80ff645 · 2025-07-29T08:32:05.000-05:00
diff --git a/R/expect-constant.R b/R/expect-constant.R
@@ -78,10 +78,7 @@ expect_waldo_constant <- function(act, constant, info, ...) {
       paste0(comp, collapse = "\n\n")
     )
     fail(msg, info = info, trace_env = caller_env())
-  } else {
-    # TODO figure out why an error return doesn't work with fail() above
-    succeed()
   }
 
-  invisible(act$val)
+  pass(act$val)
 }

Original file line number	Diff line number	Diff line change
`@@ -78,10 +78,7 @@ expect_waldo_constant <- function(act, constant, info, ...) {`
`78`	`78`	`paste0(comp, collapse = "\n\n")`
`79`	`79`	`)`
`80`	`80`	`fail(msg, info = info, trace_env = caller_env())`
`81`		`- } else {`
`82`		`- # TODO figure out why an error return doesn't work with fail() above`
`83`		`- succeed()`
`84`	`81`	`}`
`85`	`82`
`86`		`- invisible(act$val)`
	`83`	`+ pass(act$val)`
`87`	`84`	`}`