Polish snapshot_accept() tests (#2107)

Fixes #2106

---------

Co-authored-by: Hadley Wickham <[email protected]>

Author: mcol

tests/testthat/_snaps/snapshot-manage.md

@@ -3,36 +3,15 @@
     Code
       snapshot_accept(path = path)
     Message
-      Updating snapshots: 'a.md' and 'b.md'.
+      Updating snapshots: 'a.md' and 'test/b.txt'.
 
----
+# useful mesasge if no files to accept
 
     Code
       snapshot_accept(path = path)
     Message
       No snapshots to update.
 
-# can accept specific files
-
-    Code
-      snapshot_accept("a", path = path)
-    Message
-      Updating snapshots: 'a.md'.
-
----
-
-    Code
-      snapshot_accept("test/a.txt", path = path)
-    Message
-      Updating snapshots: 'test/a.txt'.
-
----
-
-    Code
-      snapshot_accept("test/", path = path)
-    Message
-      Updating snapshots: 'test/a.txt'.
-
 # can work with variants
 
     Code

tests/testthat/test-snapshot-manage.R

@@ -1,25 +1,62 @@
 test_that("informs about files being accepted", {
-  path <- local_snapshot_dir(c("a.md", "a.new.md", "b.md", "b.new.md"))
+  path <- local_snapshot_dir(c(
+    "a.md",
+    "a.new.md",
+    "test/b.txt",
+    "test/b.new.txt"
+  ))
 
   expect_snapshot(snapshot_accept(path = path))
-  expect_equal(dir(file.path(path, "_snaps")), c("a.md", "b.md"))
+  expect_equal(
+    dir(file.path(path, "_snaps"), recursive = TRUE),
+    c("a.md", "test/b.txt")
+  )
+})
 
+test_that("useful mesasge if no files to accept", {
+  path <- local_snapshot_dir(character())
   expect_snapshot(snapshot_accept(path = path))
 })
 
-test_that("can accept specific files", {
+test_that("can accept files created by expect_snapshot()", {
+  # without extension
   path <- local_snapshot_dir(c("a.md", "a.new.md", "b.md", "b.new.md"))
-  expect_snapshot(snapshot_accept("a", path = path))
+  suppressMessages(snapshot_accept("a", path = path))
   expect_equal(dir(file.path(path, "_snaps")), c("a.md", "b.md", "b.new.md"))
 
-  path <- local_snapshot_dir(c("test/a.txt", "test/a.new.txt"))
-  expect_snapshot(snapshot_accept("test/a.txt", path = path))
-  expect_equal(dir(file.path(path, "_snaps"), recursive = TRUE), "test/a.txt")
+  # with extension
+  path <- local_snapshot_dir(c("a.md", "a.new.md", "b.md", "b.new.md"))
+  suppressMessages(snapshot_accept("a.md", path = path))
+  expect_equal(dir(file.path(path, "_snaps")), c("a.md", "b.md", "b.new.md"))
 
   # or whole directory
+  path <- local_snapshot_dir(c("a.md", "a.new.md", "b.md", "b.new.md"))
+  suppressMessages(snapshot_accept(path = path))
+  expect_equal(dir(file.path(path, "_snaps")), c("a.md", "b.md"))
+})
+
+test_that("can accept files created by expect_snapshot_file()", {
   path <- local_snapshot_dir(c("test/a.txt", "test/a.new.txt"))
-  expect_snapshot(snapshot_accept("test/", path = path))
+  suppressMessages(snapshot_accept("test/a.txt", path = path))
   expect_equal(dir(file.path(path, "_snaps"), recursive = TRUE), "test/a.txt")
+
+  # including markdown files
+  path <- local_snapshot_dir(c("test/a.md", "test/a.new.md"))
+  suppressMessages(snapshot_accept("test/", path = path))
+  expect_equal(dir(file.path(path, "_snaps"), recursive = TRUE), "test/a.md")
+
+  # or the whole directory
+  path <- local_snapshot_dir(c(
+    "test/a.md",
+    "test/a.new.md",
+    "test/b.txt",
+    "test/b.new.txt"
+  ))
+  suppressMessages(snapshot_accept("test/", path = path))
+  expect_equal(
+    dir(file.path(path, "_snaps"), recursive = TRUE),
+    c("test/a.md", "test/b.txt")
+  )
 })
 
 test_that("can work with variants", {