completeness comment

MichaelChirico · MichaelChirico · commit 9aede6f34169 · 2025-07-24T16:14:01.000Z
diff --git a/R/expect-shape.R b/R/expect-shape.R
@@ -61,7 +61,7 @@ expect_shape = function(object, shape, nrow, ncol) {
       act$nrow == nrow,
       sprintf("%s has %i rows, not %i.", act$lab, act$nrow, nrow)
     )
-  } else {
+  } else { # !missing(nrow) && !missing(ncol)
     # testing both nrow & ncol (useful, e.g., for testing dim(.)[1:2] for arrays
     act$nrow <- dim_object[1L]
     act$ncol <- dim_object[2L]

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ expect_shape = function(object, shape, nrow, ncol) {`
`61`	`61`	`act$nrow == nrow,`
`62`	`62`	`sprintf("%s has %i rows, not %i.", act$lab, act$nrow, nrow)`
`63`	`63`	`)`
`64`		`- } else {`
	`64`	`+ } else { # !missing(nrow) && !missing(ncol)`
`65`	`65`	`# testing both nrow & ncol (useful, e.g., for testing dim(.)[1:2] for arrays`
`66`	`66`	`act$nrow <- dim_object[1L]`
`67`	`67`	`act$ncol <- dim_object[2L]`