Implement snapshot_reject() (#2189)

Fixes #1923

Author: hadley

NAMESPACE

@@ -192,6 +192,7 @@ export(skip_on_os)
 export(skip_on_travis)
 export(skip_unless_r)
 export(snapshot_accept)
+export(snapshot_reject)
 export(snapshot_review)
 export(source_dir)
 export(source_file)

NEWS.md

@@ -1,5 +1,6 @@
 # testthat (development version)
 
+* New `snapshot_reject()` rejects all modified snapshots by deleting the `.new` variants (#1923).
 * New `SlowReporter` makes it easier to find the slowest tests in your package. The easiest way to run it is with `devtools::test(reporter = "slow")` (#1466).
 * Power `expect_mapequal()` with `waldo::compare(list_as_map = TRUE)` (#1521).
 * On CRAN, `test_that()` now automatically skips if a package is not installed (#1585). Practically, this means that you no longer need to check that suggested packages are installed. (We don't do this in the tidyverse because we think it has limited payoff, but other styles advise differently.)

R/snapshot-manage.R

@@ -1,6 +1,7 @@
 #' Accept or reject modified snapshots
 #'
 #' * `snapshot_accept()` accepts all modified snapshots.
+#' * `snapshot_reject()` rejects all modified snapshots by deleting the `.new` variants.
 #' * `snapshot_review()` opens a Shiny app that shows a visual diff of each
 #'    modified snapshot. This is particularly useful for whole file snapshots
 #'    created by `expect_snapshot_file()`.
@@ -26,6 +27,22 @@ snapshot_accept <- function(files = NULL, path = "tests/testthat") {
   invisible()
 }
 
+#' @rdname snapshot_accept
+#' @export
+snapshot_reject <- function(files = NULL, path = "tests/testthat") {
+  changed <- snapshot_meta(files, path)
+  if (nrow(changed) == 0) {
+    inform("No snapshots to reject")
+    return(invisible())
+  }
+
+  inform(c("Rejecting snapshots:", changed$name))
+  unlink(changed$new)
+
+  rstudio_tickle()
+  invisible()
+}
+
 #' @rdname snapshot_accept
 #' @export
 snapshot_review <- function(files = NULL, path = "tests/testthat") {

man/snapshot_accept.Rd

@@ -54,3 +54,12 @@
       Updating snapshots:
       * foo/a.md
 
+# snapshot_reject deletes .new files
+
+    Code
+      snapshot_reject(path = path)
+    Message
+      Rejecting snapshots:
+      * a.md
+      * b.md
+

tests/testthat/_snaps/snapshot-manage.md

@@ -34,6 +34,13 @@ test_that("can work with variants", {
   expect_equal(dir(file.path(path, "_snaps", "foo")), "a.md")
 })
 
+test_that("snapshot_reject deletes .new files", {
+  path <- local_snapshot_dir(c("a.md", "a.new.md", "b.md", "b.new.md"))
+  
+  expect_snapshot(snapshot_reject(path = path))
+  expect_equal(dir(file.path(path, "_snaps")), c("a.md", "b.md"))
+})
+
 
 # snapshot_meta -----------------------------------------------------------