Skip to content

Commit a5b1fbb

Browse files
authored
expect_mapequal() needs to set tolerance (#2260)
To preserve same behaviour as previously
1 parent e80fdbb commit a5b1fbb

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

R/expect-setequal.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ expect_mapequal <- function(object, expected) {
109109
} else {
110110
if (edition_get() >= 3) {
111111
act <- labelled_value(act$val[exp_nms], act$lab)
112-
expect_waldo_equal_("equal", act, exp)
112+
expect_waldo_equal_("equal", act, exp, tolerance = testthat_tolerance())
113113
} else {
114114
# Packages depend on 2e behaviour, but the expectation isn't written
115115
# to be reused, and we don't want to bother

tests/testthat/test-expect-setequal.R

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,10 @@ test_that("warns if empty vector", {
9494
expect_snapshot(expect_success(expect_mapequal(list(), list())))
9595
})
9696

97+
test_that("ignores integer/numeric differences", {
98+
expect_success(expect_mapequal(list(a = 1L), list(a = 1)))
99+
})
100+
97101
test_that("uses equality behaviour of current edition", {
98102
local_edition(2)
99103
expect_success(expect_mapequal(c(a = 1), c(a = 1L)))

0 commit comments

Comments
 (0)