Refactor hint creation

Author: hadley

R/snapshot-file.R

@@ -181,11 +181,8 @@ snapshot_review_hint <- function(
   path <- paste0("tests/testthat/_snaps/", test, "/", new_name(name))
 
   if (check) {
-    gh_hint <- snap_download_hint()
-    on_gh <- !is.null(gh_hint)
-
-    if (on_gh) {
-      bullets <- gh_hint
+    if (on_gh()) {
+      bullets <- snap_download_hint()
     } else {
       bullets <- c(
         if (ci) "* Download and unzip run artifact\n",

R/snapshot-github.R

@@ -34,10 +34,6 @@ snap_download_hint <- function() {
   repository <- Sys.getenv("GITHUB_REPOSITORY")
   job_id <- Sys.getenv("GITHUB_JOB")
 
-  if (repository == "" || job_id == "") {
-    return()
-  }
-
   sprintf(
     "* Call `gh_download_snaps(\"%s\", %s)` to download the snapshots from GitHub.\n",
     repository,
@@ -119,3 +115,7 @@ dir_copy <- function(src_dir, dst_dir) {
 same_file <- function(x, y) {
   file.exists(x) && file.exists(y) && hash_file(x) == hash_file(y)
 }
+
+on_gh <- function() {
+  Sys.getenv("GITHUB_ACTIONS") == "true"
+}

tests/testthat/test-snapshot-file.R

@@ -181,7 +181,11 @@ test_that("snapshot_hint output differs in R CMD check", {
     ci = TRUE
   )))
 
-  withr::local_envvar(GITHUB_REPOSITORY = "r-lib/testthat", GITHUB_JOB = "123")
+  withr::local_envvar(
+    GITHUB_ACTIONS = "true",
+    GITHUB_REPOSITORY = "r-lib/testthat",
+    GITHUB_JOB = "123"
+  )
   expect_snapshot(cat(snapshot_review_hint(
     "lala",
     "foo.r",