move '!' outside aggregation (#2067)

Author: MichaelChirico

R/mock2.R

@@ -144,7 +144,7 @@ local_mocked_bindings <- function(..., .package = NULL, .env = caller_env()) {
     local_bindings_rebind(!!!bindings, .env = test_env, .frame = .env)
   }
 
-  if (any(!bindings_found)) {
+  if (!all(bindings_found)) {
     missing <- names(bindings)[!bindings_found]
     cli::cli_abort("Can't find binding for {.arg {missing}}")
   }

R/reporter-list.R

@@ -126,7 +126,7 @@ all_passed <- function(res) {
   }
 
   df <- as.data.frame.testthat_results(res)
-  sum(df$failed) == 0 && all(!df$error)
+  sum(df$failed) == 0 && !any(df$error)
 }
 
 any_warnings <- function(res) {

vignettes/test-fixtures.Rmd

@@ -291,7 +291,7 @@ test_that("use_roxygen_md() adds DESCRIPTION fields", {
   use_roxygen_md()
   
   expect_true(uses_roxygen_md())
-  expect_equal(desc::desc_get("Roxygen", pkg)[[1]], "list(markdown = TRUE)"))
+  expect_equal(desc::desc_get("Roxygen", pkg)[[1]], "list(markdown = TRUE)")
   expect_true(desc::desc_has_fields("RoxygenNote", pkg))
 })
 ```