Skip to content

Commit ff692f1

Browse files
committed
Update CRAN comments
1 parent 4403a6d commit ff692f1

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

cran-comments.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
## Check notes
22

3-
There is one check note in this version:
3+
0 errors | 0 warnings | 0 note
44

5-
File ‘testthat/libs/testthat.so’:
6-
Found non-API calls to R: ‘SET_BODY’, ‘SET_CLOENV’, ‘SET_FORMALS’
5+
## revdepcheck results
76

8-
The plan is to remove these calls in the next minor release. I have now informed the majority of users that these functions are going away.
7+
We checked 9992 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
98

10-
## revdepcheck results
9+
* We saw 91 new problems
10+
* We failed to check 26 packages
1111

12-
I did not check revdeps since the fixes are minor and should only decrease the number of errors.
12+
The majority of this failing tests are due to the removal of `with_mock()`/`local_mock()` since they rely on functions no longer exported the R API. I started the process of notifying package maintainers about this in January, and while a substantial number fixed their packages, unforutnately many did. For the remainder of the issues, I prepared pull requests to fix the problems (mostly bugs revealed by stricter testing). You can see my progress at <https://github.com/r-lib/testthat/issues/2243>.

0 commit comments

Comments
 (0)