- 
                Notifications
    
You must be signed in to change notification settings  - Fork 340
 
Markdown summary on GHA #1635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown summary on GHA #1635
Conversation
901d2d2    to
    574e249      
    Compare
  
    To avoid the tables from running test_file() in examples. Not the best solution.
E.g. on multi-platform windows.
| 
           Some or all of this could also live in rcmdcheck, It could read the  OTOH, for test coverage the table is very useful, because otherwise it is really hard to debug test failures there.  | 
    
| 
           Initial comments on summary at https://github.com/r-lib/testthat/actions/runs/2421804786. This looks great! Lots of ideas/nitpicks below: 
  | 
    
| 
           @hadley Thanks for the feedback, I should have said that this is a first draft. :) Yeah, most of these are possible, many of them I was planning on doing. Others are more challenging, but definitely worth taking a better look. Details soon.  | 
    
| 
           Fixes #1621  | 
    
| 
           I'm not sure how much further to push this — summaries are considerable less useful that I had expected since (as far as I can tell) you need two clicks to get to them from this page and there's no easy way to know that they exist. I think if we were to do more, it would make sense to make this part of the   | 
    
| 
           Yeah, I forgot if it is was possible to have a single summary for all runs, probably not? If not, then I don't really want this, it is too much to have a separate summary for each job, even if we improve the output. Maybe we could have a job that summarizes the tests of all jobs? But then this does not really belong in testthat.  | 
    
| 
           Yeah, my sense is that we've explored this idea and it turns out to not be that useful, and there's no point in putting more time into it.  | 
    
Cf:#1635 (comment)