R CMD check fails if `test_path()` contains subfolder named `"hold"`

[lawalter]

This is a continuation of #2083.

I created a simple reproducible R package example to illustrate the issue: https://github.com/lawalter/testingtestthat

To summarize, testthat::test_local(paste0(here::here())) passes no matter what subfolders are named under ~/tests/testthat/data/. However, R cmd check fails to access data if and only if the ~/tests/testthat/data/ subfolder is named "hold" (i.e., testthat::test_path("data", "DL0902", "hold"); subfolder "permit" and "holdz" work fine).

Example test-ignoreHolds.R:

test_that("ignoreHolds works", {

  hold_file <-
    list.files(testthat::test_path("data", "DL0902", "hold"),
               full.names = T)

  test_hold_file <-
    listFiles(testthat::test_path("data", "DL0902", "hold"))

  expect_identical(hold_file, test_hold_file[[1]])

  expect_true(length(hold_file) == 1)

  expect_true(length(test_hold_file[[1]]) == 1)
})

[hadley]

I think this is a more illustrative test:

test_that("ignoreHolds works", {
  expect_snapshot({
    test_path("data", "DL0902", "hold")
    dir.exists(test_path("data", "DL0902", "hold"))
  })
})

It shows that that directory does not exist when running R CMD check.

You can verify that this is not related to testthat by replacing the contents of tests/testthat.R with:

print(dir("testthat", recursive = TRUE))
stop("!")

This is presumably some weird R CMD check bug but I'd suggest the easiest fix is to pick a different directory name.