Add required argument to expect_true
#2240
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `required` argument to `expect_true()` that accepts `c("one", "any", "all")`. I've held off implementing for `expect_false` until we make sure the implementation is sound for easier review.
When `required = "any"` we throw an error to avoid edges with numeric vectors that contain `1` which may be coerced to `TRUE`.
Fixes r-lib#1836.
|
Thanks for working on this! I'll take it from here 😄 |
|
@snystrom thanks again for working on this. Unfortunately your code didn't make it into testthat since we ended up going in a slightly different direction, but this is not to say your work wasn't useful and appreciated! Sometimes you need to see a fully thought out implementation to realise it's not quite the right approach. We appreciate your work 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
requiredargument toexpect_true()that acceptsc("one", "any", "all"). I've held off implementing forexpect_falseuntil we make sure the implementation is sound for easier review. This also means the docstring is slightly out of sync betweenexpect_trueandexpect_falsefor now (and indeed the language could be a little nicer--I expect to polish this up too once we're aligned on the approach).When
required = "any"we throw an error to avoid edges with numeric vectors that contain1which may be coerced toTRUE.Fixes #1836.