feat: mock_output_sequence() similar to {mockery}'s multiple return values
#2061
Conversation
|
The failure on Ubuntu seems unrelated to the changes ══ Failed tests ════════════════════════════════════════════════════════════════
── Error ('test-local.R:38:3'): can override translation of error messages ─────
<notSubsettableError/error/condition>
Error in `mean[[1]]`: object of type 'closure' is not subsettable |
R/mock2-helpers.R
Outdated
| i = "You can set {.arg recycle} to {.code TRUE}." | ||
| )) | ||
| } | ||
| value <- rep_len(values, length.out = i)[[i]] |
There was a problem hiding this comment.
It'd be a little more efficient to do this with modular arithmetic, something like i <- (i - 1) %% length(values) + 1
There was a problem hiding this comment.
Aaaah I had not found this elegant solution. Code now refactored!
There was a problem hiding this comment.
(I had been using the modulo operator with if and else... 🤪 )
maelle
force-pushed
the
multiple-return
branch
from
37aa592 to
f20a031
Compare
R/mock2-helpers.R
Outdated
| #' recycled_mocked_sequence() | ||
| #' recycled_mocked_sequence() | ||
| #' @family mocking | ||
| mock_output_sequence <- function(values, recycle = FALSE) { |
There was a problem hiding this comment.
Should we use ... instead of values?
There was a problem hiding this comment.
To be sure I understand: do you mean that instead of writing mock_output_sequence(c("blop", "bla")) the user would write mock_output_sequence("blop", "bla")?
And using rlang's "Dynamic dots features"?
tests/testthat/test-mock2-helpers.R
Outdated
| expect_snapshot(mocked_sequence(), error = TRUE) | ||
| }) | ||
|
|
||
| test_that("mock_output_sequence() works -- force", { |
There was a problem hiding this comment.
I tried to write a test that'd fail if I didn't use force() but it doesn't fail so I removed force(). Maybe because of list2()? Or maybe because I missed something obvious. 😅
There was a problem hiding this comment.
Yes, it's no longer needed because list2 forces all the values in ...
|
Thanks! |
* upstream/HEAD: (250 commits) Implement `expect_shape()` (r-lib#1469) Re-enable catch tests on windows (r-lib#2104) Move digest to suggests (r-lib#2105) Support emscripten in `skip_on_os()` (r-lib#2103) Add `skip_unless_r()` (r-lib#2094) Require R 4.1 (r-lib#2101) Allow unquoting first arg for `expect_s4_class()` (r-lib#2065) typo fix (r-lib#2051) Explicitly pass `parent.frame()` in `it()` (r-lib#2086) Update vignette advice for migrating to {testthat} 3e (r-lib#2080) New praise messages (r-lib#1974) move '!' outside aggregation (r-lib#2067) Handle deprecation of std::uncaught_exception() (r-lib#2097) perf: use `anyNA()` (r-lib#2058) Upkeep (r-lib#2099) Implement `mock_output_sequence()` (r-lib#2061) Increment version number to 3.2.3.9000 Increment version number to 3.2.3 Update CRAN comments Finish off r-lib#2046 ...
2 participants
#1265 (comment)