Skip to content

Commit 1128379

Browse files
olivroyjennybc
andauthored
Add PR link to pr_finish (#1993)
* Add PR link to pr_finish * Update pr.R * Retrieve the intended component * More hyperlink tweaks --------- Co-authored-by: Jenny Bryan <[email protected]>
1 parent cc4d09c commit 1128379

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

R/pr.R

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -967,22 +967,22 @@ pr_branch_delete <- function(pr) {
967967

968968
if (is.null(pr_ref)) {
969969
ui_bullets(c(
970-
"i" = "PR {.val {pr$pr_string}} originated from branch {.val {pr_remref}},
970+
"i" = "PR {.href [{pr$pr_string}]({pr$pr_html_url})} originated from branch {.val {pr_remref}},
971971
which no longer exists."
972972
))
973973
return(invisible(FALSE))
974974
}
975975

976976
if (is.na(pr$pr_merged_at)) {
977977
ui_bullets(c(
978-
"i" = "PR {.val {pr$pr_string}} is unmerged, we will not delete the
978+
"i" = "PR {.href [{pr$pr_string}]({pr$pr_html_url})} is unmerged, we will not delete the
979979
remote branch {.val {pr_remref}}."
980980
))
981981
return(invisible(FALSE))
982982
}
983983

984984
ui_bullets(c(
985-
"v" = "PR {.val {pr$pr_string}} has been merged, deleting remote branch
985+
"v" = "PR {.href [{pr$pr_string}]({pr$pr_html_url})} has been merged, deleting remote branch
986986
{.val {pr_remref}}."
987987
))
988988
# TODO: tryCatch here?

0 commit comments

Comments
 (0)