Skip to content

Commit 14c7e63

Browse files
authored
Tweak use_github_release() so it can come before use_news_md() (#1358)
1 parent 75a0f8f commit 14c7e63

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

R/release.R

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,8 @@ release_checklist <- function(version, on_cran) {
102102
"Wait for CRAN...",
103103
"",
104104
todo("Accepted :tada:"),
105-
todo("`usethis::use_news_md()`", !has_news),
106105
todo("`usethis::use_github_release()`"),
106+
todo("`usethis::use_news_md()`", !has_news),
107107
todo("`usethis::use_dev_version()`"),
108108
todo("Update install instructions in README", !on_cran),
109109
todo("Finish blog post", type != "patch"),
@@ -156,16 +156,18 @@ use_github_release <- function(host = deprecated(),
156156
)
157157
check_branch_pushed()
158158

159-
path <- proj_path("NEWS.md")
160-
if (!file_exists(path)) {
161-
ui_stop("{ui_path('NEWS.md')} not found")
162-
}
163-
164159
cran_release <- proj_path("CRAN-RELEASE")
165160
if (file_exists(cran_release)) {
166161
file_delete(cran_release)
167162
}
168-
news <- news_latest(read_utf8(path))
163+
164+
path <- proj_path("NEWS.md")
165+
if (file_exists(path)) {
166+
news <- news_latest(read_utf8(path))
167+
} else {
168+
news <- "Initial release"
169+
}
170+
169171
package <- package_data()
170172

171173
gh <- gh_tr(tr)

tests/testthat/_snaps/release.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@
2929
Wait for CRAN...
3030
3131
* [ ] Accepted :tada:
32-
* [ ] `usethis::use_news_md()`
3332
* [ ] `usethis::use_github_release()`
33+
* [ ] `usethis::use_news_md()`
3434
* [ ] `usethis::use_dev_version()`
3535
* [ ] Update install instructions in README
3636
* [ ] Finish blog post
@@ -62,8 +62,8 @@
6262
Wait for CRAN...
6363
6464
* [ ] Accepted :tada:
65-
* [ ] `usethis::use_news_md()`
6665
* [ ] `usethis::use_github_release()`
66+
* [ ] `usethis::use_news_md()`
6767
* [ ] `usethis::use_dev_version()`
6868

6969
---
@@ -92,8 +92,8 @@
9292
Wait for CRAN...
9393
9494
* [ ] Accepted :tada:
95-
* [ ] `usethis::use_news_md()`
9695
* [ ] `usethis::use_github_release()`
96+
* [ ] `usethis::use_news_md()`
9797
* [ ] `usethis::use_dev_version()`
9898
* [ ] Finish blog post
9999
* [ ] Tweet

0 commit comments

Comments
 (0)