More general grooming of test skips

Author: jennybc

tests/testthat/test-course.R

@@ -62,7 +62,7 @@ test_that("tidy_download() errors early if destdir is not a directory", {
 
 test_that("tidy_download() works", {
   skip_on_cran()
-  skip_if_offline()
+  skip_if_offline("github.com")
 
   tmp <- withr::local_tempdir(pattern = "tidy-download-test-")
 
@@ -193,10 +193,10 @@ test_that("conspicuous_place() uses `usethis.destdir` when set", {
 })
 
 test_that("use_course() errors if MIME type is not 'application/zip'", {
-  path <- withr::local_tempdir()
-
   skip_on_cran()
   skip_if_offline()
+
+  path <- withr::local_tempdir()
   expect_usethis_error(
     use_course("https://httpbin.org/get", destdir = path),
     "does not have MIME type"

tests/testthat/test-github-actions.R

@@ -1,7 +1,8 @@
 test_that("use_github_action() allows for custom urls", {
+  skip_on_cran()
   skip_if_no_git_user()
   skip_if_offline()
-  skip_on_cran()
+
   local_interactive(FALSE)
 
   create_local_package()
@@ -21,9 +22,9 @@ test_that("use_github_action() allows for custom urls", {
 })
 
 test_that("use_github_action() appends yaml in name if missing", {
+  skip_on_cran()
   skip_if_no_git_user()
   skip_if_offline()
-  skip_on_cran()
   local_interactive(FALSE)
 
   create_local_package()
@@ -38,9 +39,9 @@ test_that("use_github_action() appends yaml in name if missing", {
 })
 
 test_that("uses_github_actions() reports usage of GitHub Actions", {
+  skip_on_cran()
   skip_if_no_git_user()
   skip_if_offline()
-  skip_on_cran()
   local_interactive(FALSE)
 
   create_local_package()
@@ -65,9 +66,9 @@ test_that("check_uses_github_actions() can throw error", {
 })
 
 test_that("use_github_actions() configures the basic check action", {
+  skip_on_cran()
   skip_if_no_git_user()
   skip_if_offline()
-  skip_on_cran()
   local_interactive(FALSE)
 
   create_local_package()
@@ -93,9 +94,9 @@ test_that("use_github_actions() configures the basic check action", {
 })
 
 test_that("use_tidy_github_actions() configures the full check and pr commands", {
+  skip_on_cran()
   skip_if_no_git_user()
   skip_if_offline()
-  skip_on_cran()
   local_interactive(FALSE)
 
   create_local_package()

tests/testthat/test-tidyverse.R

@@ -13,8 +13,8 @@ test_that("use_tidy_description() alphabetises dependencies and remotes", {
 })
 
 test_that("use_tidy_dependencies() isn't overly informative", {
-  skip_if_offline()
   skip_on_cran()
+  skip_if_offline("github.com")
 
   create_local_package(fs::path_temp("tidydeps"))
   use_package_doc()