Have use_release_issue() remind tidy packages to bump minimum R version (#1845)

* Release: bump R version if behind tidy min version

* Test bump R version

* Make tidy_minimum_r_version() return a numeric_version

Author: ateucher

R/release.R

@@ -77,6 +77,7 @@ release_checklist <- function(version, on_cran) {
   has_readme <- file_exists(proj_path("README.Rmd"))
   has_github_links <- has_github_links()
   is_posit_pkg <- is_posit_pkg()
+  tidy_min_r_version <- tidy_minimum_r_version()
 
   milestone_num <- NA # for testing (and general fallback)
   if (uses_git() && curl::has_internet()) {
@@ -111,6 +112,8 @@ release_checklist <- function(version, on_cran) {
       Check if any deprecation processes should be advanced, as described in \\
       [Gradual deprecation](https://lifecycle.r-lib.org/articles/communicate.html#gradual-deprecation)",
       type != "patch" && has_lifecycle),
+    todo("Bump required R version in DESCRIPTION to {tidy_min_r_version}",
+         is_posit_pkg && tidy_min_r_version > pkg_minimum_r_version()),
     todo("`usethis::use_news_md()`", on_cran && !has_news),
     todo("[Polish NEWS](https://style.tidyverse.org/news.html#news-release)", on_cran),
     todo("`usethis::use_github_links()`", !has_github_links),
@@ -525,3 +528,12 @@ author_has_rstudio_email <- function() {
   desc <- proj_desc()
   any(grepl("@rstudio[.]com", tolower(desc$get_authors())))
 }
+
+pkg_minimum_r_version <- function() {
+  deps <- proj_desc()$get_deps()
+  r_dep <- deps[deps$package == "R" & deps$type == "Depends", "version"]
+  if (length(r_dep) == 0) {
+    return(numeric_version(0))
+  }
+  numeric_version(gsub("[^0-9.]", "", r_dep))
+}

R/upkeep.R

@@ -283,7 +283,7 @@ tidy_minimum_r_version <- function() {
     version <- jsonlite::fromJSON(json)$version
     oldrel_4 <- re_match(version, "[0-9]+[.][0-9]+")$.match
   }
-  oldrel_4
+  numeric_version(oldrel_4)
 }
 
 lowercase_r <- function() {

tests/testthat/_snaps/release.md

@@ -136,6 +136,7 @@
       
       * [ ] `git pull`
       * [ ] Check [current CRAN check results](https://cran.rstudio.org/web/checks/check_results_{TESTPKG}.html)
+      * [ ] Bump required R version in DESCRIPTION to 3.6
       * [ ] `usethis::use_news_md()`
       * [ ] [Polish NEWS](https://style.tidyverse.org/news.html#news-release)
       * [ ] `usethis::use_github_links()`

tests/testthat/test-release.R

@@ -61,13 +61,17 @@ test_that("construct correct revdep bullet", {
 test_that("RStudio-ness detection works", {
   withr::local_options(usethis.description = NULL)
   create_local_package()
+  local_mocked_bindings(
+    tidy_minimum_r_version = function() numeric_version("3.6")
+  )
 
   expect_false(is_posit_pkg())
 
   desc <- proj_desc()
   desc$add_author(given = "PoSiT, PbC", role = "fnd")
   desc$add_author(given = "someone", email = "[email protected]")
   desc$add_urls("https://github.com/tidyverse/WHATEVER")
+  desc$set_dep("R", "Depends", version = ">= 3.4")
   desc$write()
 
   expect_true(is_posit_pkg())