Don't use ui_*() functions inside ui_code_block()

jennybc · jennybc · commit 695664ae151b · 2021-11-01T15:58:23.000-07:00
diff --git a/R/logo.R b/R/logo.R
@@ -51,8 +51,8 @@ use_logo <- function(img, geometry = "240x278", retina = TRUE) {
   ui_todo("Add logo to your README with the following html:")
   pd_link <- pkgdown_url(pedantic = TRUE)
   if (is.null(pd_link)) {
-    ui_code_block("# {pkg} <img src={ui_path(logo_path)} align=\"right\" height=\"{height}\" />")
+    ui_code_block("# {pkg} <img src=\"{proj_rel_path(logo_path)}\" align=\"right\" height=\"{height}\" />")
   } else {
-    ui_code_block("# {pkg} <a href={ui_value(pd_link)}><img src={ui_path(logo_path)} align=\"right\" height=\"{height}\" /></a>")
+    ui_code_block("# {pkg} <a href=\"{pd_link}\"><img src=\"{proj_rel_path(logo_path)}\" align=\"right\" height=\"{height}\" /></a>")
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -51,8 +51,8 @@ use_logo <- function(img, geometry = "240x278", retina = TRUE) {`
`51`	`51`	`ui_todo("Add logo to your README with the following html:")`
`52`	`52`	`pd_link <- pkgdown_url(pedantic = TRUE)`
`53`	`53`	`if (is.null(pd_link)) {`
`54`		`- ui_code_block("# {pkg} <img src={ui_path(logo_path)} align=\"right\" height=\"{height}\" />")`
	`54`	`+ ui_code_block("# {pkg} <img src=\"{proj_rel_path(logo_path)}\" align=\"right\" height=\"{height}\" />")`
`55`	`55`	`} else {`
`56`		`- ui_code_block("# {pkg} <a href={ui_value(pd_link)}><img src={ui_path(logo_path)} align=\"right\" height=\"{height}\" /></a>")`
	`56`	`+ ui_code_block("# {pkg} <a href=\"{pd_link}\"><img src=\"{proj_rel_path(logo_path)}\" align=\"right\" height=\"{height}\" /></a>")`
`57`	`57`	`}`
`58`	`58`	`}`