Advance deprecations

Author: jennybc

NAMESPACE

@@ -33,7 +33,6 @@ export(edit_rstudio_prefs)
 export(edit_rstudio_snippets)
 export(edit_template)
 export(gh_token_help)
-export(git_branch_default)
 export(git_default_branch)
 export(git_default_branch_configure)
 export(git_default_branch_rediscover)
@@ -125,11 +124,6 @@ export(use_git_protocol)
 export(use_git_remote)
 export(use_github)
 export(use_github_action)
-export(use_github_action_check_full)
-export(use_github_action_check_release)
-export(use_github_action_check_standard)
-export(use_github_action_pr_commands)
-export(use_github_actions)
 export(use_github_actions_badge)
 export(use_github_file)
 export(use_github_labels)
@@ -170,7 +164,6 @@ export(use_reprex)
 export(use_revdep)
 export(use_rmarkdown_template)
 export(use_roxygen_md)
-export(use_rscloud_badge)
 export(use_rstudio)
 export(use_rstudio_preferences)
 export(use_spell_check)
@@ -184,7 +177,6 @@ export(use_tidy_coc)
 export(use_tidy_contributing)
 export(use_tidy_dependencies)
 export(use_tidy_description)
-export(use_tidy_eval)
 export(use_tidy_github)
 export(use_tidy_github_actions)
 export(use_tidy_github_labels)

NEWS.md

@@ -27,6 +27,19 @@
   usethis's `create_*()` functions, such as opening the newly created project in
   your IDE (#1891, @focardozom).
 
+* Several deprecated functions have been removed:
+  - `use_rscloud_badge()`, deprecated in v2.2.0; use `use_posit_cloud_badge()`
+    instead
+  - `git_branch_default()`, deprecated in v2.1.0; use `git_default_branch()`
+    instead
+  - `use_tidy_eval()`, deprecated in v2.2.0; no longer necessary
+  - `use_github_actions()` and `use_github_action_check_release()`, deprecated
+    in v.2.2.0; use `use_github_action('check-release')` instead
+  - `use_github_action_check_standard()`, deprecated in v2.2.0; use
+    `use_github_action('check-standard')` instead
+  - `use_github_action_pr_commands()`, deprecated in v2.2.0
+  - `use_github_action_check_full()`, deprecated in v2.1.0
+
 # usethis 3.1.0
 
 * `use_vignette()` and `use_article()` support Quarto. The `name` of the new

R/usethis-deprecated.R

@@ -1,47 +1,8 @@
-#' Deprecated Git functions
-#'
-#' @description
-#' `r lifecycle::badge("deprecated")`
-#'
-#' `git_branch_default()` has been replaced by [git_default_branch()].
-#'
-#' @keywords internal
-#' @export
-git_branch_default <- function() {
-  lifecycle::deprecate_warn(
-    "2.1.0",
-    "git_branch_default()",
-    "git_default_branch()"
-  )
-  git_default_branch()
-}
-
-#' Deprecated badge function
-#'
-#' @description
-#' `r lifecycle::badge("deprecated")`
-#'
-#' `use_rscloud_badge()` has been replaced by [use_posit_cloud_badge()].
-#'
-#' @keywords internal
-#' @export
-use_rscloud_badge <- function(url) {
-  lifecycle::deprecate_stop(
-    "2.2.0",
-    "use_rscloud_badge()",
-    "use_posit_cloud_badge()"
-  )
-}
-
 #' Deprecated tidyverse functions
 #'
 #' @description
 #' `r lifecycle::badge("deprecated")`
 #'
-#' * `use_tidy_eval()` is deprecated because there's no longer a need to
-#'    systematically import and re-export a large number of functions in order
-#'    to use tidy evaluation. Instead, use [use_import_from()] to tactically
-#'    import functions as you need them.
 #' * `use_tidy_style()` is deprecated because tidyverse packages are moving
 #'   towards the use of [Air](https://posit-dev.github.io/air/) for formatting.
 #'   See [use_air()] for how to start using Air. To continue using the styler
@@ -51,20 +12,6 @@ use_rscloud_badge <- function(url) {
 #' @name tidy-deprecated
 NULL
 
-#' @export
-#' @rdname tidy-deprecated
-use_tidy_eval <- function() {
-  lifecycle::deprecate_stop(
-    "2.2.0",
-    "use_tidy_eval()",
-    details = c(
-      "There is no longer a need to systematically import and/or re-export functions",
-      "Instead import functions as needed, with e.g.:",
-      'usethis::use_import_from("rlang", c(".data", ".env"))'
-    )
-  )
-}
-
 #' @export
 #' @rdname tidy-deprecated
 use_tidy_style <- function(strict = TRUE) {
@@ -78,124 +25,3 @@ use_tidy_style <- function(strict = TRUE) {
     )
   )
 }
-
-# GitHub actions --------------------------------------------------------------
-
-#' Deprecated GitHub Actions functions
-#'
-#' @description
-#' `r lifecycle::badge("deprecated")`
-#'
-#' * `use_github_actions()` is deprecated because it was just an alias
-#'   for [use_github_action_check_release()].
-#'
-#' * `use_github_action_check_full()` is overkill for most packages and is
-#'    not recommended.
-#'
-#' * `use_github_action_check_release()`, `use_github_action_check_standard()`,
-#'   and `use_github_action_pr_commands()` are deprecated in favor of
-#'   [use_github_action()], which can now suggest specific workflows to use.
-#'
-#' @export
-#' @keywords internal
-use_github_actions <- function() {
-  lifecycle::deprecate_warn(
-    when = "2.2.0",
-    what = "use_github_actions()",
-    with = "use_github_action('check-release')"
-  )
-  use_github_action('check-release')
-}
-
-#' @rdname use_github_actions
-#' @export
-use_github_action_check_release <- function(
-  save_as = "R-CMD-check.yaml",
-  ref = NULL,
-  ignore = TRUE,
-  open = FALSE
-) {
-  lifecycle::deprecate_warn(
-    when = "2.2.0",
-    what = "use_github_action_check_release()",
-    with = "use_github_action('check-release')"
-  )
-
-  use_github_action(
-    "check-release.yaml",
-    ref = ref,
-    save_as = save_as,
-    ignore = ignore,
-    open = open
-  )
-  use_github_actions_badge(save_as)
-}
-
-#' @rdname use_github_actions
-#' @export
-use_github_action_check_standard <- function(
-  save_as = "R-CMD-check.yaml",
-  ref = NULL,
-  ignore = TRUE,
-  open = FALSE
-) {
-  lifecycle::deprecate_warn(
-    when = "2.2.0",
-    what = "use_github_action_check_standard()",
-    with = "use_github_action('check-standard')"
-  )
-
-  use_github_action(
-    "check-standard.yaml",
-    ref = ref,
-    save_as = save_as,
-    ignore = ignore,
-    open = open
-  )
-  use_github_actions_badge(save_as)
-}
-
-#' @rdname use_github_actions
-#' @export
-use_github_action_pr_commands <- function(
-  save_as = "pr-commands.yaml",
-  ref = NULL,
-  ignore = TRUE,
-  open = FALSE
-) {
-  lifecycle::deprecate_warn(
-    when = "2.2.0",
-    what = "use_github_action_pr_commands()",
-    with = "use_github_action('pr-commands')"
-  )
-
-  use_github_action(
-    "pr-commands.yaml",
-    ref = ref,
-    save_as = save_as,
-    ignore = ignore,
-    open = open
-  )
-}
-
-#' @rdname use_github_actions
-#' @export
-use_github_action_check_full <- function(
-  save_as = "R-CMD-check.yaml",
-  ignore = TRUE,
-  open = FALSE,
-  repo_spec = NULL
-) {
-  details <- glue(
-    "
-    It is overkill for the vast majority of R packages.
-    The \"check-full\" workflow is among those configured by \\
-    `use_tidy_github_actions()`.
-    If you really want it, request it by name with `use_github_action()`."
-  )
-  lifecycle::deprecate_stop(
-    "2.1.0",
-    "use_github_action_check_full()",
-    details = details
-  )
-}

_pkgdown.yml

@@ -157,9 +157,7 @@ reference:
     - use_rstudio_preferences
   - title: Deprecated functions
     contents:
-    - git_branch_default
-    - use_github_actions
-    - use_tidy_eval
+    - use_tidy_style
 
 articles:
 - title: Basics

man/git_branch_default.Rd

@@ -1,10 +1,3 @@
-test_that("use_tidy_eval() is deprecated", {
-  skip_if_not_installed("roxygen2")
-
-  pkg <- create_local_package()
-  expect_snapshot(use_tidy_eval(), error = TRUE)
-})
-
 test_that("use_tidy_style() is deprecated", {
   expect_snapshot(use_tidy_style())
 })