Skip to content

Commit 9210995

Browse files
committed
Oops, really update cran-comments.md, not just revdep/cran.md
1 parent 747e8f3 commit 9210995

File tree

1 file changed

+2
-25
lines changed

1 file changed

+2
-25
lines changed

cran-comments.md

Lines changed: 2 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,8 @@
1-
This patch release 2.1.3 modifies a test to ensure that intermittent GitHub rate limiting cannot lead to ungraceful failure on CRAN.
2-
3-
This submission, on 2021-10-25, is in direct response to an email from Professor Brian Ripley, also received on 2021-10-25, which states:
4-
5-
"Please correct before 2021-11-08 to safely retain your package on CRAN."
6-
71
In case it comes up, the reverse dependency tidytuesdayR regularly fails when CRAN checks usethis, due to tidytuesdayR hitting a GitHub API rate limit in its tests. This is an expected false positive and has been seen on multiple previous successful usethis submissions.
82

9-
Although that is the same phenomenon that I've just addressed in a usethis test, this is a coincidence. That is, the tidytuesdayR test failure due to GitHub rate limits is completely independent of that package's usage of usethis. Those GitHub calls are not routing through any usethis functions. The fragile tests were present before the recent usethis release and there's nothing I can do in usethis to fix the behaviour of their tests.
10-
11-
## R CMD check results
12-
13-
0 errors | 0 warnings | 1 note
14-
15-
The note is "Days since last update: 2" (see above).
16-
173
## revdepcheck results
184

19-
## revdepcheck results
20-
21-
We checked 124 reverse dependencies (123 from CRAN + 1 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
5+
We checked 134 reverse dependencies (133 from CRAN + 1 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
226

237
* We saw 0 new problems
24-
* We failed to check 1 packages
25-
26-
Issues with CRAN packages are summarised below.
27-
28-
### Failed to check
29-
30-
* butcher (NA)
31-
8+
* We failed to check 1 package (animalcules from Bioconductor)

0 commit comments

Comments
 (0)