State minimum version for gh and remove conditional code (#1088)

* Remove gh wrapper now that it's not needed

* Remove conditional code re: finding pull requests

* Fix code for case of "no releases"

Zero-length character might be a better return value but downstream code seems to rely on this NULL and I don't feel like pulling this thread

* Mention gh minimum version in NEWS

Co-authored-by: Jenny Bryan <[email protected]>

Author: hadley

DESCRIPTION

@@ -30,7 +30,7 @@ Imports:
     curl (>= 2.7),
     desc,
     fs (>= 1.3.0),
-    gh,
+    gh (>= 1.1.0),
     git2r (>= 0.23),
     glue (>= 1.3.0),
     purrr,

NEWS.md

@@ -172,6 +172,10 @@
   put a new folder created by `use_course()` or `create_from_github()`
   (@malcolmbarrett, #1015).
 
+## Dependency changes
+
+gh minimum version is stated to be v.1.1.0, due to changed behaviour around requests that return nothing.
+
 # usethis 1.5.1
 
 This is a patch release with various small features and bug fixes.

R/github-labels.R

@@ -70,7 +70,7 @@ use_github_labels <- function(repo_spec = github_repo_spec(),
   check_github_token(auth_token)
 
   gh <- function(endpoint, ...) {
-    out <- gh::gh(
+    gh::gh(
       endpoint,
       ...,
       owner = spec_owner(repo_spec),
@@ -81,11 +81,6 @@ use_github_labels <- function(repo_spec = github_repo_spec(),
         "Accept" = "application/vnd.github.symmetra-preview+json"
       )
     )
-    if (identical(out[[1]], "")) {
-      list()
-    } else {
-      out
-    }
   }
 
   cur_labels <- gh("GET /repos/:owner/:repo/labels")

R/pr.R

@@ -392,16 +392,14 @@ pr_find <- function(owner,
                     repo,
                     pr_owner = owner,
                     pr_branch = git_branch_name()) {
-  # Look at all PRs
   prs <- gh::gh("GET /repos/:owner/:repo/pulls",
     owner = owner,
     repo = repo,
     .limit = Inf,
     .token = check_github_token(allow_empty = TRUE)
   )
 
-  # prs has length zero if gh >= v1.1.0 and is "" for earlier versions
-  if (length(prs) < 1 || identical(prs[[1]], "")) {
+  if (length(prs) < 1) {
     return(character())
   }
 

R/tidyverse.R

@@ -366,7 +366,9 @@ releases <- function(repo_spec = github_repo_spec()) {
     owner = spec_owner(repo_spec),
     repo = spec_repo(repo_spec)
   )
-  if (identical(res[[1]], "")) return(NULL)
+  if (length(res) < 1) {
+    return(NULL)
+  }
   pluck_chr(res, "tag_name")
 }