Custom RStudio release bullets (#1513)

* No need to specify save_as here

* Custom RStudio release bullets

Fixes #1511

* Also use GitHub org to detect RStudio-ness

* Rescue actual changes lost in weird rebase

* Split these out so I can use them separately

* More recovering from the bad rebase

* Work on tests

Co-authored-by: Jenny Bryan <[email protected]>

Author: hadley

R/release.R

@@ -62,6 +62,7 @@ release_checklist <- function(version, on_cran) {
   has_news <- file_exists(proj_path("NEWS.md"))
   has_pkgdown <- uses_pkgdown()
   has_readme <- file_exists(proj_path("README.Rmd"))
+  is_rstudio_pkg <- is_rstudio_pkg()
 
   c(
     if (!on_cran) c(
@@ -87,10 +88,12 @@ release_checklist <- function(version, on_cran) {
     todo("`rhub::check_for_cran()`"),
     todo("`rhub::check(platform = 'ubuntu-rchk')`", has_src),
     todo("`rhub::check_with_sanitizers()`", has_src),
-    todo("`revdepcheck::revdep_check(num_workers = 4)`", on_cran),
+    todo("`revdepcheck::revdep_check(num_workers = 4)`", on_cran && !is_rstudio_pkg),
+    todo("`revdepcheck::cloud_check()`", on_cran && is_rstudio_pkg),
     todo("Update `cran-comments.md`", on_cran),
     todo("Review pkgdown reference index for, e.g., missing topics", has_pkgdown && type != "patch"),
     todo("Draft blog post", type != "patch"),
+    todo("Ping Tracy Teal on Slack", type != "patch" && is_rstudio_pkg),
     release_extra(),
     "",
     "Submit to CRAN:",
@@ -332,6 +335,38 @@ news_latest <- function(lines) {
   paste0(news, "\n", collapse = "")
 }
 
+is_rstudio_pkg <- function() {
+  is_rstudio_funded() || is_in_rstudio_org()
+}
+
+is_rstudio_funded <- function() {
+  if (!is_package()) {
+    return(FALSE)
+  }
+  desc <- desc::desc(file = proj_get())
+  funders <- unclass(desc$get_author("fnd"))
+  purrr::some(funders, ~ .x$given == "RStudio")
+}
+
+is_in_rstudio_org <- function() {
+  if (!is_package()) {
+    return(FALSE)
+  }
+  desc <- desc::desc(file = proj_get())
+  urls <- desc$get_urls()
+  dat <- parse_github_remotes(urls)
+  dat <- dat[dat$host == "github.com", ]
+  purrr::some(dat$repo_owner, ~ .x %in% rstudio_orgs())
+}
+
+rstudio_orgs <- function() {
+  c(
+    "tidyverse",
+    "r-lib",
+    "tidymodels"
+  )
+}
+
 todo <- function(x, cond = TRUE) {
   x <- glue(x, .envir = parent.frame())
   if (cond) {

tests/testthat/_snaps/release.md

@@ -1,7 +1,7 @@
 # release bullets don't change accidentally
 
     Code
-      cat(release_checklist("0.1.0", on_cran = FALSE), sep = "\n")
+      writeLines(release_checklist("0.1.0", on_cran = FALSE))
     Output
       First release:
       
@@ -40,11 +40,11 @@
 ---
 
     Code
-      cat(release_checklist("0.0.1", on_cran = TRUE), sep = "\n")
+      writeLines(release_checklist("0.0.1", on_cran = TRUE))
     Output
       Prepare for release:
       
-      * [ ] Check [current CRAN check results](https://cran.rstudio.org/web/checks/check_results_releasebullets.html)
+      * [ ] Check [current CRAN check results](https://cran.rstudio.org/web/checks/check_results_{TESTPKG}.html)
       * [ ] [Polish NEWS](https://style.tidyverse.org/news.html#news-release)
       * [ ] `urlchecker::url_check()`
       * [ ] `devtools::check(remote = TRUE, manual = TRUE)`
@@ -69,11 +69,11 @@
 ---
 
     Code
-      cat(release_checklist("1.0.0", on_cran = TRUE), sep = "\n")
+      writeLines(release_checklist("1.0.0", on_cran = TRUE))
     Output
       Prepare for release:
       
-      * [ ] Check [current CRAN check results](https://cran.rstudio.org/web/checks/check_results_releasebullets.html)
+      * [ ] Check [current CRAN check results](https://cran.rstudio.org/web/checks/check_results_{TESTPKG}.html)
       * [ ] [Polish NEWS](https://style.tidyverse.org/news.html#news-release)
       * [ ] `urlchecker::url_check()`
       * [ ] `devtools::check(remote = TRUE, manual = TRUE)`
@@ -99,3 +99,37 @@
       * [ ] Tweet
       * [ ] Add link to blog post in pkgdown news menu
 
+# RStudio-ness detection works
+
+    Code
+      writeLines(release_checklist("1.0.0", on_cran = TRUE))
+    Output
+      Prepare for release:
+      
+      * [ ] Check [current CRAN check results](https://cran.rstudio.org/web/checks/check_results_{TESTPKG}.html)
+      * [ ] [Polish NEWS](https://style.tidyverse.org/news.html#news-release)
+      * [ ] `urlchecker::url_check()`
+      * [ ] `devtools::check(remote = TRUE, manual = TRUE)`
+      * [ ] `devtools::check_win_devel()`
+      * [ ] `rhub::check_for_cran()`
+      * [ ] `revdepcheck::cloud_check()`
+      * [ ] Update `cran-comments.md`
+      * [ ] Draft blog post
+      * [ ] Ping Tracy Teal on Slack
+      
+      Submit to CRAN:
+      
+      * [ ] `usethis::use_version('major')`
+      * [ ] `devtools::submit_cran()`
+      * [ ] Approve email
+      
+      Wait for CRAN...
+      
+      * [ ] Accepted :tada:
+      * [ ] `usethis::use_github_release()`
+      * [ ] `usethis::use_dev_version()`
+      * [ ] `usethis::use_news_md()`
+      * [ ] Finish blog post
+      * [ ] Tweet
+      * [ ] Add link to blog post in pkgdown news menu
+

tests/testthat/_snaps/tidy-upkeep.md

@@ -1,7 +1,7 @@
 # upkeep bullets don't change accidentally
 
     Code
-      cat(upkeep_checklist(), sep = "\n")
+      writeLines(upkeep_checklist())
     Output
       Pre-history
       

tests/testthat/test-release.R

@@ -2,27 +2,24 @@
 # release bullets ---------------------------------------------------------
 
 test_that("release bullets don't change accidentally", {
-  # Avoid finding any files in real usethis project
-  # Take care to only change active project, but not working directory
-  # Temporary project name must be stable
-  tmpproj <- dir_create(path_temp("releasebullets"))
-  withr::defer(dir_delete(tmpproj))
-  file_create(path(tmpproj, ".here"))
-  local_project(tmpproj, setwd = FALSE)
+  create_local_package()
 
   # First release
   expect_snapshot(
-    cat(release_checklist("0.1.0", on_cran = FALSE), sep = "\n")
+    writeLines(release_checklist("0.1.0", on_cran = FALSE)),
+    transform = scrub_testpkg
   )
 
   # Patch release
   expect_snapshot(
-    cat(release_checklist("0.0.1", on_cran = TRUE), sep = "\n")
+    writeLines(release_checklist("0.0.1", on_cran = TRUE)),
+    transform = scrub_testpkg
   )
 
   # Major release
   expect_snapshot(
-    cat(release_checklist("1.0.0", on_cran = TRUE), sep = "\n")
+    writeLines(release_checklist("1.0.0", on_cran = TRUE)),
+    transform = scrub_testpkg
   )
 })
 
@@ -37,6 +34,26 @@ test_that("get extra news bullets if available", {
   expect_equal(release_extra(env), character())
 })
 
+test_that("RStudio-ness detection works", {
+  create_local_package()
+
+  expect_false(is_rstudio_funded())
+  expect_false(is_in_rstudio_org())
+
+  desc <- desc::desc(file = proj_get())
+  desc$add_author(given = "RStudio", role = "fnd")
+  desc$add_urls("https://github.com/tidyverse/WHATEVER")
+  desc$write()
+
+  expect_true(is_rstudio_funded())
+  expect_true(is_in_rstudio_org())
+
+  expect_snapshot(
+    writeLines(release_checklist("1.0.0", on_cran = TRUE)),
+    transform = scrub_testpkg
+  )
+})
+
 # news --------------------------------------------------------------------
 
 test_that("must have at least one heading", {

tests/testthat/test-tidy-upkeep.R

@@ -1,3 +1,3 @@
 test_that("upkeep bullets don't change accidentally", {
-  expect_snapshot(cat(upkeep_checklist(), sep = "\n"))
+  expect_snapshot(writeLines(upkeep_checklist()))
 })