Skip to content

Commit c5998cd

Browse files
hadleyhadley
committed
Re-run failed revdeps and update CRAN comments
1 parent 4d47139 commit c5998cd

File tree

4 files changed

+45
-75
lines changed

4 files changed

+45
-75
lines changed

‎cran-comments.md‎

Lines changed: 28 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,38 @@
1-
This is a patch release with bug fixes and small features.
2-
31
## Test environments
42

5-
* local: macOS Mojave 10.14.4 + 3.6.0
6-
* win-builder: devel and release
7-
* travis: Ubuntu 14.04.5 LTS (trusty) + 3.2, 3.3, 3.4, oldrel, release, devel
8-
* r-hub: windows-x86_64-devel, ubuntu-gcc-release, fedora-clang-devel
9-
* appveyor: Windows Server 2012 + R 3.6.0 Patched (2019-06-23 r76734)
10-
11-
usethis v1.5.0 is currently in ERROR on Solaris due to the lack of a dependency (git2r). I'm not sure why that is, but I believe it's beyond our control to fix. git2r itself has status OK on Solaris at the moment.
3+
* win-builder: R-devel
4+
* github actions (mac) 3.6, devel
5+
* github actions (windows) 3.6
6+
* github actions (linux) 3.2, 3.3, 3.4, 3.5. 3.6
127

138
## R CMD check results
149

15-
0 errors | 0 warnings | 1 note
16-
17-
There is 1 note about a "(possibly) invalid URL" in an Rd file. The URL is https://github.com/settings/tokens. The behaviour of this URL is reasonable when it is visited by human in the browser, whether they are logged into GitHub or not, but it to be expected that it 404s in a headless state.
10+
0 errors | 0 warnings | 0 notes
1811

1912
## revdepcheck results
2013

21-
We checked 39 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package. We see no differences and, in particular, no changes for the worse.
14+
We checked 64 reverse dependencies (60 from CRAN + 4 from BioConductor), comparing R CMD check results across CRAN and dev versions of this package.
15+
16+
* We saw 3 new problems
17+
* We failed to check 2 packages
18+
19+
Issues with CRAN packages are summarised below.
20+
21+
Maintainers were notified on Mar 27.
22+
23+
### New problems
24+
(This reports the first line of each new failure)
25+
26+
* DataPackageR
27+
checking tests ...
28+
29+
* devtools
30+
checking for code/documentation mismatches ... WARNING
31+
32+
* portalr
33+
checking tests ...
2234

23-
Automated check failed for 2 packages:
24-
- portalr, R CMD check timed out
25-
I re-checked manually. It seems to hang on building vignettes and testing.
26-
portalr is currently in ERROR on CRAN for several platforms.
27-
I assume I am seeing the same problem and that it's not related to usethis.
28-
- POUMM, failed to install, due to openmp issues
35+
### Failed to check
2936

30-
See our automated revdep check results at <https://github.com/r-lib/usethis/tree/master/revdep>.
37+
* codemetar (NA)
38+
* RxODE (NA)

‎revdep/README.md‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
|collate |en_US.UTF-8 |
1111
|ctype |en_US.UTF-8 |
1212
|tz |America/Chicago |
13-
|date |2020-03-23 |
13+
|date |2020-04-06 |
1414

1515
# Dependencies
1616

@@ -29,13 +29,14 @@
2929
|digest |NA |0.6.25 |* |
3030
|ellipsis |NA |0.3.0 |* |
3131
|fansi |0.4.1 |0.4.1 | |
32-
|fs |1.3.2 |1.3.2 | |
32+
|fs |1.3.2 |1.4.0 |* |
3333
|gh |1.1.0 |1.1.0 | |
3434
|git2r |0.26.1 |0.26.1 | |
3535
|glue |1.3.2 |1.3.2 | |
3636
|httr |1.4.1 |1.4.1 | |
3737
|ini |0.3.1 |0.3.1 | |
3838
|jsonlite |1.6.1 |1.6.1 | |
39+
|lifecycle |NA |0.2.0 |* |
3940
|magrittr |1.5 |1.5 | |
4041
|mime |0.9 |0.9 | |
4142
|openssl |1.4.1 |1.4.1 | |
@@ -44,12 +45,12 @@
4445
|purrr |0.3.3 |0.3.3 | |
4546
|R6 |2.4.1 |2.4.1 | |
4647
|Rcpp |1.0.4 |1.0.4 | |
47-
|rematch2 |NA |2.1.0 |* |
48+
|rematch2 |NA |2.1.1 |* |
4849
|rlang |0.4.5 |0.4.5 | |
4950
|rprojroot |1.3-2 |1.3-2 | |
5051
|rstudioapi |0.11 |0.11 | |
5152
|sys |3.3 |3.3 | |
52-
|tibble |NA |2.1.3 |* |
53+
|tibble |NA |3.0.0 |* |
5354
|utf8 |NA |1.1.4 |* |
5455
|vctrs |NA |0.2.4 |* |
5556
|whisker |0.4 |0.4 | |
@@ -65,12 +66,11 @@
6566
|codemetar |0.1.8 |1 | |1 |
6667
|RxODE |0.9.2-0 |1 | |1 |
6768

68-
## New problems (4)
69+
## New problems (3)
6970

7071
|package |version |error |warning |note |
7172
|:----------------------------------------|:-------|:------|:-------|:----|
7273
|[DataPackageR](problems.md#datapackager) |0.15.7 |__+1__ | | |
7374
|[devtools](problems.md#devtools) |2.2.2 | |__+1__ | |
74-
|[etl](problems.md#etl) |0.3.8 |__+1__ | | |
75-
|[portalr](problems.md#portalr) |0.3.1 |__+1__ | | |
75+
|[portalr](problems.md#portalr) |0.3.3 |__+1__ | | |
7676

‎revdep/failures.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* URL: https://github.com/ropensci/codemetar, https://ropensci.github.io/codemetar
88
* BugReports: https://github.com/ropensci/codemetar/issues
99
* Date/Publication: 2019-04-22 04:20:03 UTC
10-
* Number of recursive dependencies: 79
10+
* Number of recursive dependencies: 80
1111

1212
Run `revdep_details(,"codemetar")` for more info
1313

‎revdep/problems.md‎

Lines changed: 9 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ Run `revdep_details(,"DataPackageR")` for more info
2929
render_root: dummy
3030
3131
subsetCars.Rmd extra.rmd
32-
cars_over_20══ testthat results ══════════════════════════════════════════════════════════════════════════════
32+
cars_over_20══ testthat results ════════════════════════════════════════════════════════════════════════════════
3333
[ OK: 209 | SKIPPED: 0 | WARNINGS: 0 | FAILED: 1 ]
3434
1. Failure: use_ignore works (@test-ignore.R#16)
3535
@@ -60,7 +60,7 @@ Run `revdep_details(,"devtools")` for more info
6060
create
6161
Code: function(path, fields = list(), rstudio =
6262
rstudioapi::isAvailable(), roxygen = TRUE, check_name
63-
= TRUE, open = interactive())
63+
= TRUE, open = rlang::is_interactive())
6464
Docs: function(path, fields = NULL, rstudio =
6565
rstudioapi::isAvailable(), open = interactive())
6666
Argument names in code not in docs:
@@ -69,57 +69,19 @@ Run `revdep_details(,"devtools")` for more info
6969
Position: 4 Code: roxygen Docs: open
7070
Mismatches in argument default values:
7171
Name: 'fields' Code: list() Docs: NULL
72-
```
73-
74-
# etl
75-
76-
<details>
77-
78-
* Version: 0.3.8
79-
* Source code: https://github.com/cran/etl
80-
* URL: http://github.com/beanumber/etl
81-
* BugReports: https://github.com/beanumber/etl/issues
82-
* Date/Publication: 2019-12-18 18:20:02 UTC
83-
* Number of recursive dependencies: 103
84-
85-
Run `revdep_details(,"etl")` for more info
86-
87-
</details>
88-
89-
## Newly broken
90-
91-
* checking tests ...
92-
```
93-
ERROR
94-
Running the tests in ‘tests/testthat.R’ failed.
95-
Last 13 lines of output:
96-
97-
intersect, setdiff, setequal, union
98-
99-
>
100-
> test_check("etl")
101-
── 1. Failure: create ETL works (@test-etl.R#114)  ────────────────────────────────────────────────
102-
`create_etl_package\(path, open = FALSE\)` does not match "active project".
103-
Actual value: "Package: scorecard\\nTitle: What the Package Does \(One Line, Title Case\)\\nVersion: 0\.0\.0\.9000\\nAuthors@R \(parsed\):\\n \* First Last <first\.last@example\.com> \[aut, cre\] \(<https://orcid\.org/YOUR-ORCID-ID>\)\\nDescription: What the package does \(one paragraph\)\.\\nLicense: `use_mit_license\(\)`, `use_gpl3_license\(\)` or friends to pick a\\n license\\nEncoding: UTF-8\\nLazyData: true\\nRoxygen: list\(markdown = TRUE\)\\nRoxygenNote: 7\.0\.0"
104-
105-
══ testthat results ══════════════════════════════════════════════════════════════════════════════
106-
[ OK: 27 | SKIPPED: 2 | WARNINGS: 0 | FAILED: 1 ]
107-
1. Failure: create ETL works (@test-etl.R#114)
108-
109-
Error: testthat unit tests failed
110-
Execution halted
72+
Name: 'open' Code: rlang::is_interactive() Docs: interactive()
11173
```
11274
11375
# portalr
11476
11577
<details>
11678
117-
* Version: 0.3.1
79+
* Version: 0.3.3
11880
* Source code: https://github.com/cran/portalr
11981
* URL: https://weecology.github.io/portalr/, https://github.com/weecology/portalr
12082
* BugReports: https://github.com/weecology/portalr/issues
121-
* Date/Publication: 2020-01-16 15:00:02 UTC
122-
* Number of recursive dependencies: 103
83+
* Date/Publication: 2020-04-02 05:20:08 UTC
84+
* Number of recursive dependencies: 104
12385
12486
Run `revdep_details(,"portalr")` for more info
12587
@@ -134,12 +96,12 @@ Run `revdep_details(,"portalr")` for more info
13496
Last 13 lines of output:
13597
Actual value: ""
13698
137-
[31m──[39m [31m4. Failure: default data path functions work if unset (@test-01-data-retrieval.R#110) [39m [31m─────────[39m
99+
[31m──[39m [31m4. Failure: default data path functions work if unset (@test-01-data-retrieval.R#110) [39m [31m───────────[39m
138100
`m` does not match "Make sure '.Renviron' ends with a newline!".
139101
Actual value: ""
140102
141-
══ testthat results ══════════════════════════════════════════════════════════════════════════════
142-
[ OK: 193 | SKIPPED: 10 | WARNINGS: 0 | FAILED: 4 ]
103+
══ testthat results ════════════════════════════════════════════════════════════════════════════════
104+
[ OK: 194 | SKIPPED: 10 | WARNINGS: 4 | FAILED: 4 ]
143105
1. Failure: default data path functions work if unset (@test-01-data-retrieval.R#107)
144106
2. Failure: default data path functions work if unset (@test-01-data-retrieval.R#108)
145107
3. Failure: default data path functions work if unset (@test-01-data-retrieval.R#109)

0 commit comments

Comments
 (0)