Fix deprecation of path argument

Author: lionel-

R/compat-lifecycle.R

@@ -104,7 +104,7 @@ expect_doppelganger <- function(title,
   if (lifecycle::is_present(path)) {
     lifecycle::deprecate_soft(
       "1.0.0",
-      "vdiffr::expect_doppelganger(cran = )",
+      "vdiffr::expect_doppelganger(path = )",
     )
   }
 

R/expect-doppelganger.R

@@ -12,24 +12,24 @@ skip_if_maintenance <- function() {
 
 test_that("mismatches are hard failures when NOT_CRAN is set", {
   skip_if_maintenance()
-  expect_doppelganger("myplot", p1_fail, "")
+  expect_doppelganger("myplot", p1_fail)
 })
 
 test_that("Duplicated expectations issue a warning", {
   skip_if_maintenance()
-  expect_doppelganger("myplot", p1_fail, "")
+  expect_doppelganger("myplot", p1_fail)
 })
 
 test_that("mismatches are hard failures when CI is set", {
   skip_if_maintenance()
   withr::local_envvar(c(NOT_CRAN = "", CI = "true"))
-  expect_doppelganger("myplot", p1_fail, "")
+  expect_doppelganger("myplot", p1_fail)
 })
 
 test_that("mismatches are skipped when NOT_CRAN is unset", {
   skip_if_maintenance()
   withr::local_envvar(c(NOT_CRAN = "", CI = ""))
-  expect_doppelganger("myplot", p1_fail, "")
+  expect_doppelganger("myplot", p1_fail)
 })
 
 
@@ -39,5 +39,5 @@ test_that("(maintenance) Reset failing figure", {
   if (!maintenance) {
     skip("maintenance")
   }
-  expect_doppelganger("myplot", p1_orig, "")
+  expect_doppelganger("myplot", p1_orig)
 })

tests/testthat/mock-pkg/tests/testthat/test-failed.R

@@ -5,16 +5,6 @@ p2 <- ggplot2::ggplot(mtcars, ggplot2::aes(disp)) +
   ggplot2::geom_histogram()
 
 test_that("New plots are collected", {
-  expect_doppelganger("new1", p1, "")
-  expect_doppelganger("new2", p2, "")
-})
-
-test_that("Figs are saved to alternative paths", {
-  expect_doppelganger("alt1", p1, "path1")
-  expect_doppelganger("alt2", p2, "path2")
-})
-
-test_that("Figs are saved to context subfolders", {
-  expect_doppelganger("context1", p1)
-  expect_doppelganger("context2", p2)
+  expect_doppelganger("new1", p1)
+  expect_doppelganger("new2", p2)
 })

tests/testthat/mock-pkg/tests/testthat/test-new.R

@@ -2,19 +2,19 @@ library("vdiffr")
 
 test_that("ggplot doppelgangers pass", {
   p1_orig <- ggplot2::ggplot(mtcars, ggplot2::aes(disp)) + ggplot2::geom_histogram()
-  expect_doppelganger("myplot", p1_orig, "")
+  expect_doppelganger("myplot", p1_orig)
 })
 
 test_that("base doppelgangers pass", {
   p_base <- function() plot(mtcars$disp)
-  expect_doppelganger("myplot2", p_base, "")
+  expect_doppelganger("myplot2", p_base)
 
   p_base_symbol <- function() {
     plot.new()
     text(0.5, 0.8, expression(x[i] + over(x, y)), font = 5)
   }
 
-  expect_doppelganger("Base doppelganger with symbol", p_base_symbol, "")
+  expect_doppelganger("Base doppelganger with symbol", p_base_symbol)
 })
 
 library("grid")