Merge pull request #37 from thomasp85/patch-2

Add `print_plot()` method for grob

Author: lionel-

NAMESPACE

@@ -3,6 +3,7 @@
 S3method(print_plot,"function")
 S3method(print_plot,default)
 S3method(print_plot,ggplot)
+S3method(print_plot,grob)
 S3method(print_plot,recordedplot)
 export(expect_doppelganger)
 export(write_svg)

NEWS.md

@@ -25,6 +25,12 @@ There are two steps to update your snapshots to vdiffr 1.0.
    run `devtools::test()`, and then `testthat::snapshot_review()`.
 
 
+## Other changes
+
+* `expect_doppelganger()` now supports grid objects such as `gtable`
+  and `grob` (#36).
+
+
 # vdiffr 0.4.0
 
 This is a github-only release that is meant to help you migrate from

R/svg.R

@@ -43,6 +43,11 @@ print_plot.ggplot <- function(p, title = "") {
   print(p)
 }
 
+#' @export
+print_plot.grob <- function(p, title) {
+  grid::grid.draw(p)
+}
+
 #' @export
 print_plot.recordedplot <- function(p, title) {
   grDevices::replayPlot(p)

tests/testthat/_snaps/expect-doppelganger/grob.svg

@@ -72,11 +72,20 @@ test_that("no 'svglite supports one page' error (#85)", {
       widths = unit(c(0.05, 0.9, 0.05), "npc"),
       heights = unit(c(0.05, 0.9, 0.05), "npc")
     )
-    gt <- gtable_add_grob(gt, list(axes_grob), 2, 2, clip = "off")
-    plot(gt)
+    gtable_add_grob(gt, list(axes_grob), 2, 2, clip = "off")
   }
   environment(test_draw_axis) <- env(ns_env("ggplot2"))
 
   expect_doppelganger("page-error1", test_draw_axis(FALSE))
   expect_doppelganger("page-error2", test_draw_axis(TRUE))
 })
+
+test_that("supports `grob` objects (#36)", {
+  circle <- grid::circleGrob(
+    x = 0.5,
+    y = 0.5,
+    r = 0.5,
+    gp = grid::gpar(col = "gray", lty = 3)
+  )
+  expect_doppelganger("grob", circle)
+})