Signal failure when testting interactively

Author: lionel-

R/utils.R

@@ -172,5 +172,5 @@ hash_encode_url <- function(url){
 }
 
 is_ci <- function() {
-  nzchar(Sys.getenv("CI"))
+  nzchar(Sys.getenv("CI")) || nzchar(Sys.getenv("NOT_CRAN"))
 }

tests/mock.Rout.fail

@@ -43,3 +43,43 @@ Failed doppelganger: myplot (../figs//myplot.svg)
   Mi41Mg==)' />                                                             
   <defs>                                                                    
 
+
+Failed doppelganger: myplot (../figs//myplot.svg)
+
+< before                                                                    
+> after                                                                     
+@@ 50,4 / 50,5 @@                                                           
+  <rect x='641.72' y='401.98' width='20.80' height='118.58' style='stroke-wi
+  dth: 1.07; stroke: none; stroke-linecap: butt; fill: #595959;' clip-path='
+  url(#cpMjguMDl8NzE0LjUyfDU0NC4yN3wyMi41Mg==)' />                          
+  <rect x='662.52' y='401.98' width='20.80' height='118.58' style='stroke-wi
+  dth: 1.07; stroke: none; stroke-linecap: butt; fill: #595959;' clip-path='
+  url(#cpMjguMDl8NzE0LjUyfDU0NC4yN3wyMi41Mg==)' />                          
+> <line x1='417.09' y1='544.27' x2='417.09' y2='22.52' style='stroke-width: 
+: 1.07; stroke-linecap: butt;' clip-path='url(#cpMjguMDl8NzE0LjUyfDU0NC4yN3w
+: yMi41Mg==)' />                                                            
+  <rect x='28.09' y='22.52' width='686.43' height='521.75' style='stroke-wid
+  th: 1.07; stroke: #333333;' clip-path='url(#cpMjguMDl8NzE0LjUyfDU0NC4yN3wy
+  Mi41Mg==)' />                                                             
+  <defs>                                                                    
+
+
+Failed doppelganger: myplot (../figs//myplot.svg)
+
+< before                                                                    
+> after                                                                     
+@@ 50,4 / 50,5 @@                                                           
+  <rect x='641.72' y='401.98' width='20.80' height='118.58' style='stroke-wi
+  dth: 1.07; stroke: none; stroke-linecap: butt; fill: #595959;' clip-path='
+  url(#cpMjguMDl8NzE0LjUyfDU0NC4yN3wyMi41Mg==)' />                          
+  <rect x='662.52' y='401.98' width='20.80' height='118.58' style='stroke-wi
+  dth: 1.07; stroke: none; stroke-linecap: butt; fill: #595959;' clip-path='
+  url(#cpMjguMDl8NzE0LjUyfDU0NC4yN3wyMi41Mg==)' />                          
+> <line x1='417.09' y1='544.27' x2='417.09' y2='22.52' style='stroke-width: 
+: 1.07; stroke-linecap: butt;' clip-path='url(#cpMjguMDl8NzE0LjUyfDU0NC4yN3w
+: yMi41Mg==)' />                                                            
+  <rect x='28.09' y='22.52' width='686.43' height='521.75' style='stroke-wid
+  th: 1.07; stroke: #333333;' clip-path='url(#cpMjguMDl8NzE0LjUyfDU0NC4yN3wy
+  Mi41Mg==)' />                                                             
+  <defs>                                                                    
+

tests/testthat/mock-pkg/tests/testthat/test-failed.R

@@ -12,7 +12,7 @@ skip_if_maintenance <- function() {
   }
 }
 
-test_that("New plots work are collected", {
+test_that("mismatches are hard failures when NOT_CRAN is set", {
   skip_if_maintenance()
   expect_doppelganger("myplot", p1_fail, "")
 })
@@ -22,9 +22,15 @@ test_that("Duplicated expectations issue a warning", {
   expect_doppelganger("myplot", p1_fail, "")
 })
 
-test_that("figure mismatches are hard failures on CI", {
+test_that("mismatches are hard failures when CI is set", {
   skip_if_maintenance()
-  withr::local_envvar(c(CI = "true"))
+  withr::local_envvar(c(NOT_CRAN = "", CI = "true"))
+  expect_doppelganger("myplot", p1_fail, "")
+})
+
+test_that("mismatches are skipped when NOT_CRAN is unset", {
+  skip_if_maintenance()
+  withr::local_envvar(c(NOT_CRAN = "", CI = ""))
   expect_doppelganger("myplot", p1_fail, "")
 })
 

tests/testthat/test-expectations.R

@@ -1,14 +1,18 @@
 
 context("Expectations")
 
-test_that("Mismatches are skipped except on CI", {
-  skipped_result <- subset_results(test_results, "test-failed.R", "New plots work are collected")[[1]]
-  expect_match(skipped_result$message, "Figures don't match: myplot.svg\n")
-  expect_is(skipped_result, "expectation_regression")
+test_that("Mismatches are skipped except on CI and interactively", {
+  notcran_result <- subset_results(test_results, "test-failed.R", "mismatches are hard failures when NOT_CRAN is set")[[1]]
+  expect_match(notcran_result$message, "Figures don't match: myplot.svg\n")
+  expect_is(notcran_result, "expectation_failure")
 
-  failed_result <- subset_results(test_results, "test-failed.R", "figure mismatches are hard failures on CI")[[1]]
+  failed_result <- subset_results(test_results, "test-failed.R", "mismatches are hard failures when CI is set")[[1]]
   expect_match(failed_result$message, "Figures don't match: myplot.svg\n")
   expect_is(failed_result, "expectation_failure")
+
+  skipped_result <- subset_results(test_results, "test-failed.R", "mismatches are skipped when NOT_CRAN is unset")[[1]]
+  expect_match(skipped_result$message, "Figures don't match: myplot.svg\n")
+  expect_is(skipped_result, "expectation_regression")
 })
 
 test_that("Duplicated expectations issue warning", {