Skip to content

Commit f58a08b

Browse files
committed
Extract case_declare()
1 parent e0d01b7 commit f58a08b

File tree

1 file changed

+13
-9
lines changed

1 file changed

+13
-9
lines changed

R/testthat-ui.R

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -111,15 +111,9 @@ expect_doppelganger <- function(title,
111111
))
112112

113113
if (file.exists(path)) {
114-
exp <- compare_figs(case)
114+
exp <- case_compare(case)
115115
} else {
116-
case <- new_case(case)
117-
maybe_collect_case(case)
118-
msg <- paste_line(
119-
sprintf("Figure not generated yet: %s.svg", fig_name),
120-
"Please run `vdiffr::manage_cases()` to validate the figure."
121-
)
122-
exp <- new_exp(msg, case)
116+
exp <- case_declare(case, fig_name)
123117
}
124118

125119
signal_expectation(exp)
@@ -138,7 +132,7 @@ str_standardise <- function(s, sep = "-") {
138132
s
139133
}
140134

141-
compare_figs <- function(case) {
135+
case_compare <- function(case) {
142136
equal <- compare_files(case$testcase, normalizePath(case$path))
143137

144138
if (equal) {
@@ -154,6 +148,16 @@ compare_figs <- function(case) {
154148
msg <- paste0("Figures don't match: ", case$name, ".svg\n")
155149
mismatch_exp(msg, case)
156150
}
151+
case_declare <- function(case, fig_name) {
152+
case <- new_case(case)
153+
maybe_collect_case(case)
154+
155+
msg <- paste_line(
156+
sprintf("Figure not generated yet: %s.svg", fig_name),
157+
"Please run `vdiffr::manage_cases()` to validate the figure."
158+
)
159+
new_exp(msg, case)
160+
}
157161

158162
new_expectation <- function(msg, case, type, vdiffr_type) {
159163
exp <- testthat::expectation(type, msg)

0 commit comments

Comments
 (0)