Skip to content

Commit 1920936

Browse files
committed
Upgrade to gifski 1.6.6
1 parent 6b86cc6 commit 1920936

File tree

7 files changed

+297
-134
lines changed

7 files changed

+297
-134
lines changed

.Rbuildignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,4 @@
99
\.gif$
1010
\.github$
1111
^src/.cargo
12+
^\.github$

.github/workflows/R-CMD-check.yaml

Lines changed: 21 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
# For help debugging build failures open an issue on the RStudio community with the 'github-actions' tag.
2-
# https://community.rstudio.com/new-topic?category=Package%20development&tags=github-actions
1+
# Workflow derived from https://github.com/r-lib/actions/tree/v2/examples
2+
# Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help
33
on:
44
push:
55
pull_request:
@@ -16,26 +16,21 @@ jobs:
1616
fail-fast: false
1717
matrix:
1818
config:
19-
- {os: windows-latest, r: 'oldrel'}
20-
- {os: windows-latest, r: 'release'}
19+
- {os: windows-latest, r: '3.6'}
20+
- {os: windows-latest, r: '4.1'}
21+
- {os: windows-latest, r: 'next'}
2122
- {os: macOS-latest, r: 'release'}
22-
- {os: ubuntu-16.04, r: 'release', rspm: "https://packagemanager.rstudio.com/cran/__linux__/xenial/latest"}
23-
- {os: ubuntu-18.04, r: 'release', rspm: "https://packagemanager.rstudio.com/cran/__linux__/bionic/latest"}
24-
- {os: ubuntu-20.04, r: 'release', rspm: "https://packagemanager.rstudio.com/cran/__linux__/focal/latest"}
25-
- {os: ubuntu-20.04, r: 'devel', rspm: "https://packagemanager.rstudio.com/cran/__linux__/focal/latest"}
23+
- {os: ubuntu-latest, r: 'devel', http-user-agent: 'release'}
24+
- {os: ubuntu-latest, r: 'release'}
25+
- {os: ubuntu-18.04, r: 'oldrel-1'}
2626

2727
env:
28-
R_REMOTES_NO_ERRORS_FROM_WARNINGS: true
29-
RSPM: ${{ matrix.config.rspm }}
3028
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
29+
R_KEEP_PKG_SOURCE: yes
3130

3231
steps:
3332
- uses: actions/checkout@v2
3433

35-
- uses: r-lib/actions/setup-r@v1
36-
with:
37-
r-version: ${{ matrix.config.r }}
38-
3934
- name: Install Rust on Linux
4035
if: runner.os == 'Linux'
4136
run: sudo apt-get install -y cargo
@@ -48,39 +43,23 @@ jobs:
4843
override: true
4944

5045
- name: Add more rust targets
51-
if: runner.os == 'Windows' && matrix.config.r == 'release'
46+
if: runner.os == 'Windows'
5247
run: |
5348
rustup target add i686-pc-windows-gnu
5449
rustup target add x86_64-pc-windows-gnu
5550
Copy-Item src\Makevars.win.rust src\Makevars.win
5651
57-
- name: Temporary toolchain hack
58-
if: runner.os == 'Windows' && matrix.config.r == 'release'
59-
run: cp -f /mingw64/lib/gcc/x86_64-w64-mingw32/8.3.0/libgcc.a /mingw64/lib/gcc/x86_64-w64-mingw32/8.3.0/libgcc_eh.a
60-
shell: c:\rtools40\usr\bin\bash.exe --login {0}
61-
62-
- name: Query dependencies
63-
run: |
64-
install.packages('remotes')
65-
saveRDS(remotes::dev_package_deps(dependencies = TRUE), ".github/depends.Rds", version = 2)
66-
writeLines(sprintf("R-%i.%i", getRversion()$major, getRversion()$minor), ".github/R-version")
67-
shell: Rscript {0}
68-
69-
- name: Install dependencies
70-
run: |
71-
remotes::install_deps(dependencies = TRUE)
72-
remotes::install_cran("rcmdcheck")
73-
shell: Rscript {0}
52+
- uses: r-lib/actions/setup-r@v2
53+
with:
54+
r-version: ${{ matrix.config.r }}
55+
http-user-agent: ${{ matrix.config.http-user-agent }}
56+
use-public-rspm: true
7457

75-
- name: Check
76-
env:
77-
_R_CHECK_CRAN_INCOMING_REMOTE_: false
78-
run: rcmdcheck::rcmdcheck(args = c("--no-manual", "--as-cran"), error_on = "warning", check_dir = "check")
79-
shell: Rscript {0}
58+
- uses: r-lib/actions/setup-r-dependencies@v2
59+
with:
60+
extra-packages: any::rcmdcheck
61+
needs: check
8062

81-
- name: Upload check results
82-
if: failure()
83-
uses: actions/upload-artifact@main
63+
- uses: r-lib/actions/check-r-package@v2
8464
with:
85-
name: ${{ runner.os }}-r${{ matrix.config.r }}-results
86-
path: check
65+
upload-results: true

src/Makevars.win

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ VERSION = 1.4.3
22
RWINLIB = ../windows/gifski-$(VERSION)
33
PKG_CPPFLAGS = -I$(RWINLIB)/include
44
PKG_LIBS = -L$(RWINLIB)/lib${R_ARCH}${CRT} \
5-
-lgifski -lws2_32 -ladvapi32 -luserenv -ldbghelp
5+
-lgifski -lws2_32 -ladvapi32 -luserenv -ldbghelp -lbcrypt
66

77
all: clean winlibs
88

src/Makevars.win.rust

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
TARGET = $(subst 64,x86_64,$(subst 32,i686,$(WIN)))-pc-windows-gnu
22
LIBDIR = myrustlib/target/$(TARGET)/release
33
STATLIB = $(LIBDIR)/libmyrustlib.a
4-
PKG_LIBS = -L$(LIBDIR) -lmyrustlib -lws2_32 -ladvapi32 -luserenv -ldbghelp
4+
PKG_LIBS = -L$(LIBDIR) -lmyrustlib -lws2_32 -ladvapi32 -luserenv -ldbghelp -lbcrypt
55

66
# These can also be set in ~/.cargo/config
77
#export CARGO_TARGET_I686_PC_WINDOWS_GNU_LINKER=C:\\rtools40\\mingw$(WIN)\\bin\\gcc
@@ -10,8 +10,9 @@ PKG_LIBS = -L$(LIBDIR) -lmyrustlib -lws2_32 -ladvapi32 -luserenv -ldbghelp
1010

1111
# This bypasses the exception stuff
1212
#export CARGO_TARGET_I686_PC_WINDOWS_GNU_RUSTFLAGS=-C panic=abort
13-
13+
ifeq ($(R_COMPILED_BY),gcc 8.3.0)
1414
GCCPATH=$(subst C:\,/c/,$(RTOOLS40_HOME))/mingw$(WIN)/bin
15+
endif
1516

1617
all: clean
1718

0 commit comments

Comments
 (0)