removed 404 page in lieu of json error response + set gloabl json content type

Author: jakewmeyer

app.js

@@ -6,7 +6,6 @@ const compression = require("compression")
 const helmet = require("helmet")
 const config = require("./config.json")
 const MongoClient = require("mongodb")
-const Path = require("path")
 const app = express()
 
 const home  = require("./routes/v1-home")
@@ -30,9 +29,15 @@ app.use("/v1/launches", launches)
 app.use("/v1/launches/upcoming", upcoming)
 app.use("/v1/parts", parts)
 
+// Global content type
+app.use((req, res, next) => {
+  res.header("Content-Type","application/json")
+  next()
+})
+
 // 404 Error Handler
 app.use((req, res) => {
-  res.status(404).sendFile(Path.join(__dirname + "/pages/404.html"))
+  res.status(404).json("No Endpoint Found")
 })
 
 MongoClient.connect(config.url, (err, database) => {

pages/404.html

@@ -12,9 +12,10 @@ beforeAll((done) => {
 //                     404 Page
 //------------------------------------------------------------
 
-test("It should return 404 page", () => {
+test("It should return 404 endpoint error", () => {
   return request(app).get("/v2").then(response => {
     expect(response.statusCode).toBe(404)
+    expect(response.text).toContain("No Endpoint Found")
   })
 })