fix: improve error handling in role assignment

Author: wiktoriavh

src/commands/onboarding/index.ts

@@ -46,8 +46,21 @@ export const onboardingCommand = createCommand({
 
     collector.on('collect', async (componentInteraction) => {
       if (componentInteraction.customId === 'onboarding_add_role') {
-        const member = await guild.members.fetch(componentInteraction.user.id);
-        await addRoleToUser(member, onboardingRole, componentInteraction);
+        try {
+          const member = await guild.members.fetch(componentInteraction.user.id);
+          await addRoleToUser(member, onboardingRole);
+
+          await componentInteraction.reply({
+            content: `You have been given the ${onboardingRole.name} role!`,
+            flags: MessageFlags.Ephemeral,
+          });
+        } catch (error) {
+          await componentInteraction.reply({
+            content: `Failed to add role. Please contact an administrator.`,
+            flags: MessageFlags.Ephemeral,
+          });
+          console.error('Error adding role:\n', error);
+        }
       }
     });
   },

src/util/addRoleToUser.ts

@@ -1,40 +1,14 @@
-import {
-  type ButtonInteraction,
-  type CacheType,
-  type ChannelSelectMenuInteraction,
-  type GuildMember,
-  type MentionableSelectMenuInteraction,
-  MessageFlags,
-  type Role,
-  type RoleSelectMenuInteraction,
-  type StringSelectMenuInteraction,
-  type UserSelectMenuInteraction,
-} from 'discord.js';
+import type { GuildMember, Role } from 'discord.js';
 
-type ComponentInteraction =
-  | ButtonInteraction<CacheType>
-  | StringSelectMenuInteraction<CacheType>
-  | UserSelectMenuInteraction<CacheType>
-  | RoleSelectMenuInteraction<CacheType>
-  | MentionableSelectMenuInteraction<CacheType>
-  | ChannelSelectMenuInteraction<CacheType>;
-
-export async function addRoleToUser(
-  member: GuildMember,
-  role: Role,
-  interaction: ComponentInteraction
-) {
+export async function addRoleToUser(member: GuildMember, role: Role): Promise<void> {
   const hasRole = member.roles.cache.has(role.id);
-  if (hasRole) {
-    await interaction.reply({
-      content: `You already have the ${role.name} role.`,
-      flags: MessageFlags.Ephemeral,
-    });
-  } else {
-    await member.roles.add(role);
-    await interaction.reply({
-      content: `You have been given the ${role.name} role!`,
-      flags: MessageFlags.Ephemeral,
-    });
+  if (!hasRole) {
+    try {
+      await member.roles.add(role);
+    } catch (error) {
+      throw new Error(
+        `Failed to add role "${role.name}" to user "${member.user.username}": ${error instanceof Error ? error.message : String(error)}`
+      );
+    }
   }
 }