chore(pop-cli): remove contract from default features (#1003)

* chore: remove contracts as default feat

* chore: CI still runs contract tests

* fix: leaking integration-tests feat

chore: wrong subs

Author: al3mart

.github/workflows/ci.yml

@@ -121,7 +121,7 @@ jobs:
         uses: actions-rs/clippy-check@v1
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
-          args: --all-targets -- -D warnings
+          args: --no-default-features --features telemetry,contract,chain --all-targets -- -D warnings
 
   docker:
     runs-on: ubuntu-latest
@@ -154,8 +154,8 @@ jobs:
           shared-key: pop-cache-docs
           save-if: ${{ github.ref == 'refs/heads/main' }}
 
-      - name: Check no default features
-        run: cargo doc --locked --no-deps
+      - name: Check all features
+        run: cargo doc --locked --no-default-features --features telemetry,contract,chain --no-deps
 
   documentation-tests:
     needs:
@@ -184,4 +184,4 @@ jobs:
           shared-key: pop-cache
 
       - name: Run doc tests
-        run: cargo test --locked --doc
+        run: cargo test --locked --no-default-features --features telemetry,contract,chain --doc

.github/workflows/coverage.yml

@@ -70,7 +70,7 @@ jobs:
       - name: Build and archive instrumented tests
         run: |
           source <(cargo llvm-cov show-env --export-prefix --target x86_64-unknown-linux-gnu --coverage-target-only)
-          cargo nextest archive --locked --workspace --lib --bins --archive-file nextest-archive.tar.zst
+          cargo nextest archive --locked --workspace --no-default-features --features telemetry,contract,chain --lib --bins --archive-file nextest-archive.tar.zst
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 

AGENTS.md

@@ -15,9 +15,9 @@ Pop CLI is organized as a Cargo workspace:
 - Packaging and release assets live in `debian/`, `Dockerfile*`, and `flake.nix`/`flake.lock` for Nix builds.
 
 ### Feature Flags
-- **Default features**: `["chain", "telemetry", "contract"]`
+- **Default features**: `["chain", "telemetry"]`
 - **`chain`** - Parachain development tools (includes `wallet-integration`)
-- **`contract`** - ink! smart contract support (includes `wallet-integration`)
+- **`contract`** - ink! smart contract support (opt-in, includes `wallet-integration`)
 - **`telemetry`** - Anonymous usage analytics
 - **`wallet-integration`** - Browser wallet connectivity for signing transactions
 - **`integration-tests`** - Enable integration test helpers in pop-common
@@ -46,7 +46,7 @@ Commands in `crates/pop-cli/src/commands/`:
 ## Build, Test, and Development Commands
 
 ### Build
-- `cargo build` - Build with default features (chain, contract, telemetry)
+- `cargo build` - Build with default features (chain, telemetry)
 - `cargo build --no-default-features --features chain` - Build for parachain functionality only
 - `cargo build --no-default-features --features contract` - Build for smart contracts functionality only
 

README.md

@@ -106,18 +106,32 @@ On the [Pop Docs website](https://learn.onpop.io) you will find:
 
 ## Building Pop CLI locally
 
-Build the tool only for Parachain functionality:
+Build with default features (parachain support):
+
+```sh
+cargo build
+```
+
+Build with Smart Contracts support (opt-in):
+
+```sh
+cargo build --features contract
+```
+
+Build for parachain functionality only:
 
 ```sh
 cargo build --no-default-features --features chain
 ```
 
-Build the tool only for Smart Contracts functionality:
+Build for Smart Contracts functionality only:
 
 ```sh
 cargo build --no-default-features --features contract
 ```
 
+> :information_source: Smart contract (ink!) support is available as an opt-in feature. To install with contract support: `cargo install pop-cli --locked --features contract`
+
 ## Testing Pop CLI
 
 To test the tool locally. Due to the time it can take to build a Parachain or a Smart Contract, some tests have been

crates/pop-cli/Cargo.toml

@@ -82,7 +82,7 @@ scale.workspace = true
 temp-env.workspace = true
 
 [features]
-default = ["chain", "telemetry", "contract"]
+default = ["chain", "telemetry"]
 chain = ["dep:pop-chains", "dep:pop-fork", "dep:git2", "dep:tracing-subscriber", "dep:scale-value", "wallet-integration"]
 contract = ["dep:pop-contracts", "wallet-integration"]
 telemetry = ["dep:pop-telemetry"]

crates/pop-cli/src/main.rs

@@ -342,6 +342,7 @@ mod tests {
 				"call chain"
 			);
 			// Call contract command display.
+			#[cfg(feature = "contract")]
 			assert_eq!(
 				Cli {
 					json: false,