refactor: replace UrlSearchParam to querystring module

Author: jbl428

lib/builders/request-param.builder.spec.ts

@@ -0,0 +1,40 @@
+import { describe, it, expect } from "vitest";
+import { RequestParamBuilder } from "./request-param.builder";
+
+describe("RequestParamBuilder", () => {
+  it("should build query string with explicit key", () => {
+    // given
+    const builder = new RequestParamBuilder(0, "keyword");
+    const args = ["search"];
+
+    // when
+    const actual = builder.build(args);
+
+    // then
+    expect(actual).toBe("?keyword=search");
+  });
+
+  it("should build query string without key", () => {
+    // given
+    const builder = new RequestParamBuilder(1);
+    const args = ["invalid", { foo: "bar" }];
+
+    // when
+    const actual = builder.build(args);
+
+    // then
+    expect(actual).toBe("?foo=bar");
+  });
+
+  it("should encode query string", () => {
+    // given
+    const builder = new RequestParamBuilder(0, "keyword");
+    const args = ["?@#$%^&+ "];
+
+    // when
+    const actual = builder.build(args);
+
+    // then
+    expect(actual).toBe("?keyword=%3F%40%23%24%25%5E%26%2B%20");
+  });
+});

lib/builders/request-param.builder.ts

@@ -1,3 +1,4 @@
+import querystring from "node:querystring";
 import { TupleArrayBuilder } from "./tuple-array.builder";
 
 export class RequestParamBuilder {
@@ -20,20 +21,24 @@ export class RequestParamBuilder {
       return "";
     }
 
-    const searchParams = new URLSearchParams();
-    this.metadata.forEach(([index, key]) => {
-      if (key != null) {
-        searchParams.set(key, args[index]);
-        return;
-      }
-
-      TupleArrayBuilder.of<string, unknown>(args[index]).forEach(
-        ([key, value]) => {
-          searchParams.set(key, `${value?.toString() ?? ""}`);
+    const result = this.metadata.reduce<Record<string, any>>(
+      (acc, [index, key]) => {
+        if (key != null) {
+          acc[key] = args[index];
+          return acc;
         }
-      );
-    });
 
-    return "?" + searchParams.toString();
+        TupleArrayBuilder.of<string, unknown>(args[index]).forEach(
+          ([key, value]) => {
+            acc[key] = value;
+          }
+        );
+
+        return acc;
+      },
+      {}
+    );
+
+    return "?" + querystring.stringify(result);
   }
 }