test: enhance test coverage

Author: jbl428

lib/builders/url.builder.spec.ts

@@ -74,4 +74,18 @@ describe('UrlBuilder', () => {
     // then
     expect(actual).toBe('https://example.com/api/user?keyword=search');
   });
+
+  test('should strip duplicated slash', () => {
+    // given
+    const host = '//example.com';
+    const path = '//api///user';
+    const args = [1];
+    const urlBuilder = new UrlBuilder(host, path, args);
+
+    // when
+    const actual = urlBuilder.build();
+
+    // then
+    expect(actual).toBe('/example.com/api/user');
+  });
 });

lib/decorators/path-variable.decorator.spec.ts

@@ -4,6 +4,25 @@ import { PathVariable } from './path-variable.decorator';
 import { type PathVariableBuilder } from '../builders/path-variable.builder';
 
 describe('PathVariable', () => {
+  test('should not create path variable metadata when not on method', () => {
+    // given
+    class TestService {
+      constructor(@PathVariable('foo') foo: string) {
+        return foo;
+      }
+    }
+
+    // when
+    const result = Reflect.getMetadata(
+      PATH_VARIABLE_METADATA,
+      TestService.prototype,
+      'request',
+    );
+
+    // then
+    expect(result).toBeUndefined();
+  });
+
   test('should set path variable metadata', () => {
     // given
     class TestService {

lib/decorators/request-body.decorator.spec.ts

@@ -5,6 +5,25 @@ import { type RequestBodyBuilder } from '../builders/request-body.builder';
 import { type RequestParamBuilder } from '../builders/request-param.builder';
 
 describe('RequestBody', () => {
+  test('should not create request body metadata when not on method', () => {
+    // given
+    class TestService {
+      constructor(@RequestBody() foo: string) {
+        return foo;
+      }
+    }
+
+    // when
+    const result = Reflect.getMetadata(
+      REQUEST_BODY_METADATA,
+      TestService.prototype,
+      'request',
+    );
+
+    // then
+    expect(result).toBeUndefined();
+  });
+
   test('should set request body metadata with empty key', () => {
     // given
     class TestService {

lib/decorators/request-form.decorator.spec.ts

@@ -5,6 +5,25 @@ import { type RequestFormBuilder } from '../builders/request-form.builder';
 import { type RequestParamBuilder } from '../builders/request-param.builder';
 
 describe('RequestForm', () => {
+  test('should not create request form metadata when not on method', () => {
+    // given
+    class TestService {
+      constructor(@RequestForm() foo: string) {
+        return foo;
+      }
+    }
+
+    // when
+    const result = Reflect.getMetadata(
+      REQUEST_FORM_METADATA,
+      TestService.prototype,
+      'request',
+    );
+
+    // then
+    expect(result).toBeUndefined();
+  });
+
   test('should set request form metadata with empty key', () => {
     // given
     class TestService {

lib/decorators/request-header.decorator.spec.ts

@@ -2,8 +2,28 @@ import { describe, test, expect } from 'vitest';
 import { REQUEST_HEADER_METADATA } from './constants';
 import { RequestHeader } from './request-header.decorator';
 import { type RequestHeaderBuilder } from '../builders/request-header.builder';
+import { type RequestParamBuilder } from '../builders/request-param.builder';
 
 describe('RequestHeader', () => {
+  test('should not create request header metadata when not on method', () => {
+    // given
+    class TestService {
+      constructor(@RequestHeader() foo: string) {
+        return foo;
+      }
+    }
+
+    // when
+    const result = Reflect.getMetadata(
+      REQUEST_HEADER_METADATA,
+      TestService.prototype,
+      'request',
+    );
+
+    // then
+    expect(result).toBeUndefined();
+  });
+
   test('should set request header metadata with empty key', () => {
     // given
     class TestService {
@@ -41,4 +61,29 @@ describe('RequestHeader', () => {
     // then
     expect(result.metadata).toEqual([[0, 'foo']]);
   });
+
+  test('should set request header metadata with multiple decorator', () => {
+    // given
+    class TestService {
+      request(
+        @RequestHeader('foo') foo: string,
+        @RequestHeader() bar: { bar: string },
+      ): string {
+        return foo;
+      }
+    }
+
+    // when
+    const result: RequestParamBuilder = Reflect.getMetadata(
+      REQUEST_HEADER_METADATA,
+      TestService.prototype,
+      'request',
+    );
+
+    // then
+    expect(result.metadata).toEqual([
+      [1, undefined],
+      [0, 'foo'],
+    ]);
+  });
 });

lib/decorators/request-param.decorator.spec.ts

@@ -4,6 +4,25 @@ import { RequestParam } from './request-param.decorator';
 import { type RequestParamBuilder } from '../builders/request-param.builder';
 
 describe('RequestParam', () => {
+  test('should not create request param metadata when not on method', () => {
+    // given
+    class TestService {
+      constructor(@RequestParam() foo: string) {
+        return foo;
+      }
+    }
+
+    // when
+    const result = Reflect.getMetadata(
+      REQUEST_PARAM_METADATA,
+      TestService.prototype,
+      'request',
+    );
+
+    // then
+    expect(result).toBeUndefined();
+  });
+
   test('should set request param metadata with empty key', () => {
     // given
     class TestService {

lib/fixtures/stub-http-client.ts

@@ -9,11 +9,7 @@ export class StubHttpClient implements HttpClient {
 
     const response = this.#responses.shift();
 
-    if (typeof response === 'undefined') {
-      throw new Error('empty response array');
-    }
-
-    return response;
+    return response ?? new Response('{}', { status: 404 });
   }
 
   get requestInfo(): Request[] {

lib/node-fetch.injector.spec.ts

@@ -11,6 +11,7 @@ import {
   PostExchange,
   PutExchange,
   RequestBody,
+  RequestForm,
   RequestParam,
 } from './decorators';
 import { StubDiscoveryService } from './fixtures/stub-discovery.service';
@@ -80,7 +81,6 @@ describe('NodeFetchInjector', () => {
       }
     }
     const instance = discoveryService.addProvider(SampleClient);
-    httpClient.addResponse({ status: 'ok' });
     nodeFetchInjector.onModuleInit();
 
     // when
@@ -101,7 +101,6 @@ describe('NodeFetchInjector', () => {
       }
     }
     const instance = discoveryService.addProvider(SampleClient);
-    httpClient.addResponse({ status: 'ok' });
     nodeFetchInjector.onModuleInit();
 
     // when
@@ -127,7 +126,6 @@ describe('NodeFetchInjector', () => {
       }
     }
     const instance = discoveryService.addProvider(SampleClient);
-    httpClient.addResponse({ status: 'ok' });
     nodeFetchInjector.onModuleInit();
 
     // when
@@ -150,7 +148,6 @@ describe('NodeFetchInjector', () => {
       }
     }
     const instance = discoveryService.addProvider(SampleClient);
-    httpClient.addResponse({ status: 'ok' });
     nodeFetchInjector.onModuleInit();
 
     // when
@@ -175,7 +172,6 @@ describe('NodeFetchInjector', () => {
       }
     }
     const instance = discoveryService.addProvider(SampleClient);
-    httpClient.addResponse({ status: 'ok' });
     nodeFetchInjector.onModuleInit();
 
     // when
@@ -206,7 +202,6 @@ describe('NodeFetchInjector', () => {
       }
     }
     const instance = discoveryService.addProvider(SampleClient);
-    httpClient.addResponse({ status: 'ok' });
     nodeFetchInjector.onModuleInit();
 
     // when
@@ -266,4 +261,32 @@ describe('NodeFetchInjector', () => {
       'application/json',
     );
   });
+
+  test('should include body provided by form', async () => {
+    // given
+    @HttpInterface()
+    class SampleClient {
+      @PostExchange('https://example.com/api')
+      async request(
+        @RequestForm() body: Record<string, unknown>,
+      ): Promise<string> {
+        return 'request';
+      }
+    }
+    const instance = discoveryService.addProvider(SampleClient);
+    httpClient.addResponse({ status: 'ok' });
+    nodeFetchInjector.onModuleInit();
+
+    // when
+    await instance.request({ foo: 'bar' });
+
+    // then
+    expect(httpClient.requestInfo).toHaveLength(1);
+    expect(await httpClient.requestInfo[0].text()).toContain(
+      `Content-Disposition: form-data; name="foo"`,
+    );
+    expect(httpClient.requestInfo[0].headers.get('Content-Type')).toBe(
+      'application/x-www-form-urlencoded',
+    );
+  });
 });