refactor(test_runner): make Target::cargo_features return owned strings

Author: yvt

src/r3_test_runner/src/targets.rs

@@ -18,7 +18,7 @@ pub trait Target: Send + Sync {
 
     /// Get the additional Cargo features to enable when building
     /// `r3_port_*_test_driver`.
-    fn cargo_features(&self) -> &[&str];
+    fn cargo_features(&self) -> Vec<String>;
 
     /// Generate the `memory.x` file to be included by the linker script of
     /// `cortex-m-rt` or `r3_port_arm`, or to be used as the top-level
@@ -62,7 +62,7 @@ impl<T: Target> Target for OverrideTargetArch<T> {
         self.0
     }
 
-    fn cargo_features(&self) -> &[&str] {
+    fn cargo_features(&self) -> Vec<String> {
         self.1.cargo_features()
     }
 

src/r3_test_runner/src/targets/jlink.rs

@@ -26,13 +26,13 @@ impl Target for RedV {
         Arch::RV32IMAC
     }
 
-    fn cargo_features(&self) -> &[&str] {
-        &[
-            "boot-rt",
-            "output-rtt",
-            "interrupt-e310x",
-            "board-e310x-red-v",
-            "r3_port_riscv/emulate-lr-sc",
+    fn cargo_features(&self) -> Vec<String> {
+        vec![
+            "boot-rt".to_owned(),
+            "output-rtt".to_owned(),
+            "interrupt-e310x".to_owned(),
+            "board-e310x-red-v".to_owned(),
+            "r3_port_riscv/emulate-lr-sc".to_owned(),
         ]
     }
 

src/r3_test_runner/src/targets/kflash.rs

@@ -25,13 +25,13 @@ impl Target for Maix {
         Arch::RV64GC
     }
 
-    fn cargo_features(&self) -> &[&str] {
-        &[
-            "boot-rt",
-            "output-k210-uart",
-            "interrupt-k210",
-            "board-maix",
-            "r3_port_riscv/maintain-pie",
+    fn cargo_features(&self) -> Vec<String> {
+        vec![
+            "boot-rt".to_owned(),
+            "output-k210-uart".to_owned(),
+            "interrupt-k210".to_owned(),
+            "board-maix".to_owned(),
+            "r3_port_riscv/maintain-pie".to_owned(),
         ]
     }
 

src/r3_test_runner/src/targets/openocd.rs

@@ -23,8 +23,8 @@ impl Target for GrPeach {
         Arch::CORTEX_A9
     }
 
-    fn cargo_features(&self) -> &[&str] {
-        &["board-rza1"]
+    fn cargo_features(&self) -> Vec<String> {
+        vec!["board-rza1".to_owned()]
     }
 
     fn memory_layout_script(&self) -> String {

src/r3_test_runner/src/targets/probe_rs.rs

@@ -25,8 +25,8 @@ impl Target for NucleoF401re {
         Arch::CORTEX_M4F
     }
 
-    fn cargo_features(&self) -> &[&str] {
-        &["output-rtt"]
+    fn cargo_features(&self) -> Vec<String> {
+        vec!["output-rtt".to_owned()]
     }
 
     fn memory_layout_script(&self) -> String {

src/r3_test_runner/src/targets/qemu/arm.rs

@@ -11,8 +11,8 @@ impl Target for QemuMps2An385 {
         Arch::CORTEX_M3
     }
 
-    fn cargo_features(&self) -> &[&str] {
-        &["output-semihosting"]
+    fn cargo_features(&self) -> Vec<String> {
+        vec!["output-semihosting".to_owned()]
     }
 
     fn memory_layout_script(&self) -> String {
@@ -52,8 +52,8 @@ impl Target for QemuMps2An505 {
         Arch::CORTEX_M33_FPU
     }
 
-    fn cargo_features(&self) -> &[&str] {
-        &["output-semihosting"]
+    fn cargo_features(&self) -> Vec<String> {
+        vec!["output-semihosting".to_owned()]
     }
 
     fn memory_layout_script(&self) -> String {
@@ -95,8 +95,8 @@ impl Target for QemuRealviewPbxA9 {
         Arch::CORTEX_A9
     }
 
-    fn cargo_features(&self) -> &[&str] {
-        &["board-realview_pbx_a9"]
+    fn cargo_features(&self) -> Vec<String> {
+        vec!["board-realview_pbx_a9".to_owned()]
     }
 
     fn memory_layout_script(&self) -> String {

src/r3_test_runner/src/targets/qemu/riscv.rs

@@ -15,12 +15,12 @@ impl Target for QemuSiFiveE {
         }
     }
 
-    fn cargo_features(&self) -> &[&str] {
-        &[
-            "boot-rt",
-            "output-e310x-uart",
-            "interrupt-e310x",
-            "board-e310x-qemu",
+    fn cargo_features(&self) -> Vec<String> {
+        vec![
+            "boot-rt".to_owned(),
+            "output-e310x-uart".to_owned(),
+            "interrupt-e310x".to_owned(),
+            "board-e310x-qemu".to_owned(),
         ]
     }
 
@@ -84,12 +84,12 @@ impl Target for QemuSiFiveU {
         }
     }
 
-    fn cargo_features(&self) -> &[&str] {
-        &[
-            "boot-rt",
-            "output-u540-uart",
-            "interrupt-u540-qemu",
-            "board-u540-qemu",
+    fn cargo_features(&self) -> Vec<String> {
+        vec![
+            "boot-rt".to_owned(),
+            "output-u540-uart".to_owned(),
+            "interrupt-u540-qemu".to_owned(),
+            "board-u540-qemu".to_owned(),
         ]
     }
 

src/r3_test_runner/src/targets/rp_pico.rs

@@ -35,8 +35,8 @@ impl Target for RaspberryPiPico {
         Arch::CORTEX_M0
     }
 
-    fn cargo_features(&self) -> &[&str] {
-        &["board-rp_pico"]
+    fn cargo_features(&self) -> Vec<String> {
+        vec!["board-rp_pico".to_owned()]
     }
 
     fn memory_layout_script(&self) -> String {