Skip to content

Commit ff5c815

Browse files
committed
refactor(port_std): simplify generic parameters
1 parent e970838 commit ff5c815

File tree

1 file changed

+10
-15
lines changed
  • src/constance_port_std/src

1 file changed

+10
-15
lines changed

src/constance_port_std/src/lib.rs

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ impl State {
257257
{
258258
unsafe { self.enter_cpu_lock() };
259259
unsafe { System::choose_running_task() };
260-
unsafe { self.leave_cpu_lock::<System>() };
260+
unsafe { self.leave_cpu_lock() };
261261

262262
let mut lock = self.thread_group.get().unwrap().lock();
263263

@@ -310,15 +310,10 @@ impl State {
310310
self.pend_interrupt_line(INTERRUPT_LINE_DISPATCH).unwrap();
311311
}
312312

313-
pub unsafe fn exit_and_dispatch<System: Kernel>(
313+
pub unsafe fn exit_and_dispatch<System: PortInstance>(
314314
&'static self,
315315
task: &'static TaskCb<System>,
316-
) -> !
317-
where
318-
System: Port<PortTaskState = TaskState>,
319-
// Work-around <https://github.com/rust-lang/rust/issues/43475>
320-
System::TaskReadyQueue: std::borrow::BorrowMut<[StaticListHead<TaskCb<System>>]>,
321-
{
316+
) -> ! {
322317
log::trace!("exit_and_dispatch");
323318
assert!(self.is_cpu_lock_active());
324319

@@ -335,7 +330,7 @@ impl State {
335330
lock.scheduler().cpu_lock = true;
336331
}
337332

338-
pub unsafe fn leave_cpu_lock<System: Kernel>(&'static self) {
333+
pub unsafe fn leave_cpu_lock(&'static self) {
339334
log::trace!("leave_cpu_lock");
340335

341336
let mut lock = self.thread_group.get().unwrap().lock();
@@ -348,10 +343,10 @@ impl State {
348343
}
349344
}
350345

351-
pub unsafe fn initialize_task_state<System: Kernel>(&self, task: &'static TaskCb<System>)
352-
where
353-
System: Port<PortTaskState = TaskState>,
354-
{
346+
pub unsafe fn initialize_task_state<System: PortInstance>(
347+
&self,
348+
task: &'static TaskCb<System>,
349+
) {
355350
log::trace!("initialize_task_state {:p}", task);
356351

357352
let pts = &task.port_task_state;
@@ -609,15 +604,15 @@ macro_rules! use_port {
609604
}
610605

611606
unsafe fn exit_and_dispatch(task: &'static TaskCb<Self>) -> ! {
612-
PORT_STATE.exit_and_dispatch::<Self>(task);
607+
PORT_STATE.exit_and_dispatch(task);
613608
}
614609

615610
unsafe fn enter_cpu_lock() {
616611
PORT_STATE.enter_cpu_lock()
617612
}
618613

619614
unsafe fn leave_cpu_lock() {
620-
PORT_STATE.leave_cpu_lock::<Self>()
615+
PORT_STATE.leave_cpu_lock()
621616
}
622617

623618
unsafe fn initialize_task_state(task: &'static TaskCb<Self>) {

0 commit comments

Comments
 (0)