AzureMachines: set disk caching to ReadWrite

patrickdillon · patrickdillon · commit 00bc79bb493e · 2024-05-10T11:18:19.000-04:00
Change Azure Masters to use ReadWrite cache. The write is then lazily written to the disk when the cache is flushed periodically. Customers can additionally force a flush by issuing an f/sync or fua command. etcd should be ok with this change since etcd does fsyncs when needed. https://learn.microsoft.com/en-us/azure/virtual-machines/disks-performance Based on Terraform changes in: openshift#8380
diff --git a/pkg/asset/machines/azure/azuremachines.go b/pkg/asset/machines/azure/azuremachines.go
@@ -83,6 +83,7 @@ func GenerateMachines(platform *azure.Platform, pool *types.MachinePool, userDat
 		ManagedDisk: &capz.ManagedDiskParameters{
 			StorageAccountType: mpool.DiskType,
 		},
+		CachingType: "ReadWrite",
 	}
 	ultrassd := mpool.UltraSSDCapability == "Enabled"
 	additionalCapabilities := &capz.AdditionalCapabilities{

Original file line number	Diff line number	Diff line change
`@@ -83,6 +83,7 @@ func GenerateMachines(platform azure.Platform, pool types.MachinePool, userDat`
`83`	`83`	`ManagedDisk: &capz.ManagedDiskParameters{`
`84`	`84`	`StorageAccountType: mpool.DiskType,`
`85`	`85`	`},`
	`86`	`+ CachingType: "ReadWrite",`
`86`	`87`	`}`
`87`	`88`	`ultrassd := mpool.UltraSSDCapability == "Enabled"`
`88`	`89`	`additionalCapabilities := &capz.AdditionalCapabilities{`