terraform vs infra sdk capv folder create

With the terraform vsphere provider its nearly
impossible to create multiple nested folders.

The introduction using govmomi to create the
pre-requisite objects in vCenter elivates
that problem.

To resolve the validation issue the folder
function is split between two files.

If terraform is used the confirmation that the folder
exist is still present.

If capv/altinfra is used the folder does not need
to be present and continues if not.

These files should only be needed until terraform
is removed entirely.

Author: jcpowermac

pkg/asset/installconfig/vsphere/folder.go

@@ -0,0 +1,36 @@
+//go:build !altinfra
+// +build !altinfra
+
+package vsphere
+
+import (
+	"context"
+	"time"
+
+	"k8s.io/apimachinery/pkg/util/validation/field"
+)
+
+// folderExists returns an error if a folder is specified in the vSphere platform but a folder with that name is not found in the datacenter.
+func folderExists(validationCtx *validationContext, folderPath string, fldPath *field.Path) field.ErrorList {
+	allErrs := field.ErrorList{}
+	finder := validationCtx.Finder
+	// If no folder is specified, skip this check as the folder will be created.
+	if folderPath == "" {
+		return allErrs
+	}
+
+	ctx, cancel := context.WithTimeout(context.TODO(), 60*time.Second)
+	defer cancel()
+
+	folder, err := finder.Folder(ctx, folderPath)
+	if err != nil {
+		return append(allErrs, field.Invalid(fldPath, folderPath, err.Error()))
+	}
+	permissionGroup := permissions[permissionFolder]
+
+	err = comparePrivileges(ctx, validationCtx, folder.Reference(), permissionGroup)
+	if err != nil {
+		return append(allErrs, field.InternalError(fldPath, err))
+	}
+	return allErrs
+}

pkg/asset/installconfig/vsphere/folder_altinfra.go

@@ -0,0 +1,44 @@
+//go:build altinfra
+// +build altinfra
+
+package vsphere
+
+import (
+	"context"
+	"errors"
+	"time"
+
+	"github.com/vmware/govmomi/find"
+	"k8s.io/apimachinery/pkg/util/validation/field"
+)
+
+// folderExists returns an error if a folder is specified in the vSphere platform but a folder with that name is not found in the datacenter.
+func folderExists(validationCtx *validationContext, folderPath string, fldPath *field.Path) field.ErrorList {
+	var notFoundError *find.NotFoundError
+	allErrs := field.ErrorList{}
+	finder := validationCtx.Finder
+	// If no folder is specified, skip this check as the folder will be created.
+	if folderPath == "" {
+		return allErrs
+	}
+
+	ctx, cancel := context.WithTimeout(context.TODO(), 60*time.Second)
+	defer cancel()
+
+	folder, err := finder.Folder(ctx, folderPath)
+	if err != nil && !errors.As(err, &notFoundError) {
+		return append(allErrs, field.Invalid(fldPath, folderPath, err.Error()))
+	}
+
+	// folder was not found so no privilege check can be performed
+	if folder == nil {
+		return allErrs
+	}
+	permissionGroup := permissions[permissionFolder]
+
+	err = comparePrivileges(ctx, validationCtx, folder.Reference(), permissionGroup)
+	if err != nil {
+		return append(allErrs, field.InternalError(fldPath, err))
+	}
+	return allErrs
+}

pkg/asset/installconfig/vsphere/validation.go

@@ -190,31 +190,6 @@ func validateFailureDomain(validationCtx *validationContext, failureDomain *vsph
 	return allErrs
 }
 
-// folderExists returns an error if a folder is specified in the vSphere platform but a folder with that name is not found in the datacenter.
-func folderExists(validationCtx *validationContext, folderPath string, fldPath *field.Path) field.ErrorList {
-	allErrs := field.ErrorList{}
-	finder := validationCtx.Finder
-	// If no folder is specified, skip this check as the folder will be created.
-	if folderPath == "" {
-		return allErrs
-	}
-
-	ctx, cancel := context.WithTimeout(context.TODO(), 60*time.Second)
-	defer cancel()
-
-	folder, err := finder.Folder(ctx, folderPath)
-	if err != nil {
-		return append(allErrs, field.Invalid(fldPath, folderPath, err.Error()))
-	}
-	permissionGroup := permissions[permissionFolder]
-
-	err = comparePrivileges(ctx, validationCtx, folder.Reference(), permissionGroup)
-	if err != nil {
-		return append(allErrs, field.InternalError(fldPath, err))
-	}
-	return allErrs
-}
-
 func validateVCenterVersion(validationCtx *validationContext, fldPath *field.Path) field.ErrorList {
 	allErrs := field.ErrorList{}