Merge pull request openshift#7570 from shiftstack/move-controlplaneport-ga

OSASINFRA-3237: move controlPlanePort API to GA

Author: openshift-merge-bot[bot]

data/data/install.openshift.io_installconfigs.yaml

@@ -3703,8 +3703,7 @@ spec:
                       for dualstack clusters. Providing this configuration will prevent
                       OpenShift from managing or updating this network and its subnets.
                       The network and its subnets will be used during creation of
-                      all nodes. This is a TechPreview feature and requires setting
-                      featureSet to TechPreviewNoUpgrade.
+                      all nodes.
                     properties:
                       fixedIPs:
                         description: Specify subnets of the network where control

docs/user/openstack/deploy_dual_stack_cluster.md

@@ -49,7 +49,6 @@ Now that the Networking resources are pre-created you can deploy OpenShift. Here
 ```yaml
 apiVersion: v1
 baseDomain: mydomain.test
-featureSet: TechPreviewNoUpgrade
 compute:
 - name: worker
   platform:
@@ -92,4 +91,4 @@ platform:
 ```
 There are important things to note:
 
-The subnets under `platform.openstack.controlPlanePort.fixedIPs` can contain both id or name. The same applies to the network `platform.openstack.controlPlanePort.network`. Dual-stack clusters are only supported with `featureSet: TechPreviewNoUpgrade`
+The subnets under `platform.openstack.controlPlanePort.fixedIPs` can contain both id or name. The same applies to the network `platform.openstack.controlPlanePort.network`.

pkg/types/openstack/platform.go

@@ -123,7 +123,6 @@ type Platform struct {
 	// ControlPlanePort contains details of the network attached to the control plane port, with the network either containing one openstack
 	// subnet for IPv4 or two openstack subnets for dualstack clusters. Providing this configuration will prevent OpenShift from managing
 	// or updating this network and its subnets. The network and its subnets will be used during creation of all nodes.
-	// This is a TechPreview feature and requires setting featureSet to TechPreviewNoUpgrade.
 	// +optional
 	ControlPlanePort *PortTarget `json:"controlPlanePort,omitempty"`
 

pkg/types/openstack/validation/techpreview.go

@@ -1105,17 +1105,6 @@ func validateCustomFeatureGates(c *types.InstallConfig) field.ErrorList {
 func validateGatedFeatures(c *types.InstallConfig) field.ErrorList {
 	allErrs := field.ErrorList{}
 
-	// legacy feature gating
-	if c.FeatureSet != configv1.TechPreviewNoUpgrade {
-		errMsg := "the TechPreviewNoUpgrade feature set must be enabled to use this field"
-
-		if c.OpenStack != nil {
-			for _, f := range openstackvalidation.FilledInTechPreviewFields(c) {
-				allErrs = append(allErrs, field.Forbidden(f, errMsg))
-			}
-		}
-	}
-
 	gatedFeatures := []featuregates.GatedInstallConfigFeature{}
 	switch {
 	case c.GCP != nil: