Validate release arch when possible

Author: jeffdyoung

pkg/asset/agent/installconfig.go

@@ -12,6 +12,7 @@ import (
 	"github.com/openshift/assisted-service/models"
 	"github.com/openshift/installer/pkg/asset"
 	"github.com/openshift/installer/pkg/asset/installconfig"
+	"github.com/openshift/installer/pkg/asset/releaseimage"
 	"github.com/openshift/installer/pkg/types"
 	"github.com/openshift/installer/pkg/types/baremetal"
 	baremetaldefaults "github.com/openshift/installer/pkg/types/baremetal/defaults"
@@ -79,6 +80,9 @@ func (a *OptionalInstallConfig) validateInstallConfig(installConfig *types.Insta
 	if err := a.validateSupportedArchs(installConfig); err != nil {
 		allErrs = append(allErrs, err...)
 	}
+	if err := a.validateReleaseArch(installConfig); err != nil {
+		allErrs = append(allErrs, err...)
+	}
 
 	if installConfig.FeatureSet != configv1.Default {
 		allErrs = append(allErrs, field.NotSupported(field.NewPath("FeatureSet"), installConfig.FeatureSet, []string{string(configv1.Default)}))
@@ -129,6 +133,34 @@ func (a *OptionalInstallConfig) validateSupportedPlatforms(installConfig *types.
 	return allErrs
 }
 
+func (a *OptionalInstallConfig) validateReleaseArch(installConfig *types.InstallConfig) field.ErrorList {
+	var allErrs field.ErrorList
+
+	fieldPath := field.NewPath("ControlPlane", "Architecture")
+	releaseImage := &releaseimage.Image{}
+	asseterr := releaseImage.Generate(asset.Parents{})
+	if asseterr != nil {
+		allErrs = append(allErrs, field.InternalError(fieldPath, asseterr))
+	}
+	releaseArch, err := DetermineReleaseImageArch(installConfig.PullSecret, releaseImage.PullSpec)
+	if err != nil {
+		logrus.Warnf("Unable to validate the release image architecture, skipping validation")
+	} else {
+		// Validate that the release image supports the install-config architectures.
+		switch releaseArch {
+		// Check the release image to see if it is multi.
+		case "multi":
+			logrus.Debugf("multi architecture release image %s found, all archs supported", releaseImage.PullSpec)
+		// If the release image isn't multi, then its single arch, and it must match the cpu architecture.
+		case string(installConfig.ControlPlane.Architecture):
+			logrus.Debugf("Supported architecture %s found for the release image: %s", installConfig.ControlPlane.Architecture, releaseImage.PullSpec)
+		default:
+			allErrs = append(allErrs, field.Forbidden(fieldPath, fmt.Sprintf("unsupported release image architecture. ControlPlane Arch: %s doesn't match Release Image Arch: %s", installConfig.ControlPlane.Architecture, releaseArch)))
+		}
+	}
+	return allErrs
+}
+
 func (a *OptionalInstallConfig) validateSupportedArchs(installConfig *types.InstallConfig) field.ErrorList {
 	var allErrs field.ErrorList