Merge pull request openshift#6707 from shiftstack/204_nocontent_objects

OCPBUGS-4941: OpenStack: Force JSON content-type in Swift object listing

Author: openshift-merge-robot

pkg/destroy/openstack/openstack.go

@@ -1106,6 +1106,20 @@ func deleteContainers(opts *clientconfig.ClientOpts, filter Filter, logger logru
 			if metadata[titlekey] == val {
 				logger.Debugf("Bulk deleting container %q objects", container)
 				pager := objects.List(conn, container, &objects.ListOpts{
+					// Listing with `Full == true` so that Gophercloud sets the `Accept`
+					// header to `application/json`. If `Full` is not true, Gophercloud
+					// sets `Accept: text/plain`, to which some objectstorage instances may
+					// respond with an HTTP status code of 204 in case there are no
+					// occurrences to list. Some, but not all, of these objectstorage
+					// instances omit the `content-type` header from their 204 responses.
+					// While being perfectly correct, this case is mishandled by the
+					// currently vendored version of Gophercloud. On the other hand, the
+					// JSON response always HTTP status code 200, a JSON content (possibly
+					// `{}`), and most importantly a `content-type` header.
+					//
+					// This option can be reverted to `false` once Gophercloud learns to
+					// correctly handle empty 204 responses.
+					Full:  true,
 					Limit: 50,
 				})
 				err = pager.EachPage(func(page pagination.Page) (bool, error) {