Use PreProvision

Move to the PreProvision interface to pre-create the required
vsphere infrastructure components prior to capi/capv running.

Author: jcpowermac

pkg/asset/cluster/cluster.go

@@ -14,7 +14,6 @@ import (
 	"github.com/openshift/installer/pkg/asset/cluster/azure"
 	"github.com/openshift/installer/pkg/asset/cluster/openstack"
 	"github.com/openshift/installer/pkg/asset/cluster/tfvars"
-	vcentercontexts "github.com/openshift/installer/pkg/asset/cluster/vsphere"
 	"github.com/openshift/installer/pkg/asset/ignition/bootstrap"
 	"github.com/openshift/installer/pkg/asset/ignition/machine"
 	"github.com/openshift/installer/pkg/asset/installconfig"
@@ -62,7 +61,6 @@ func (c *Cluster) Dependencies() []asset.Asset {
 		&installconfig.PlatformCredsCheck{},
 		&installconfig.PlatformPermsCheck{},
 		&installconfig.PlatformProvisionCheck{},
-		&vcentercontexts.VCenterContexts{},
 		&quota.PlatformQuotaCheck{},
 		&tfvars.TerraformVariables{},
 		&password.KubeadminPassword{},

pkg/asset/cluster/vsphere/context.go

@@ -11,7 +11,6 @@ func Metadata(config *types.InstallConfig) *typesvsphere.Metadata {
 
 	// Since currently we only support a single vCenter
 	// just use the first entry in the VCenters slice.
-
 	return &typesvsphere.Metadata{
 		VCenter:           config.VSphere.VCenters[0].Server,
 		Username:          config.VSphere.VCenters[0].Username,

pkg/asset/cluster/vsphere/vsphere.go

@@ -34,6 +34,7 @@ type InstallConfig struct {
 	Azure    *icazure.Metadata    `json:"azure,omitempty"`
 	IBMCloud *icibmcloud.Metadata `json:"ibmcloud,omitempty"`
 	PowerVS  *icpowervs.Metadata  `json:"powervs,omitempty"`
+	VSphere  *icvsphere.Metadata  `json:"vsphere,omitempty"`
 }
 
 var _ asset.WritableAsset = (*InstallConfig)(nil)
@@ -152,6 +153,13 @@ func (a *InstallConfig) finish(filename string) error {
 	if a.Config.PowerVS != nil {
 		a.PowerVS = icpowervs.NewMetadata(a.Config.BaseDomain)
 	}
+	if a.Config.VSphere != nil {
+		a.VSphere = icvsphere.NewMetadata()
+
+		for _, v := range a.Config.VSphere.VCenters {
+			_ = a.VSphere.AddCredentials(v.Server, v.Username, v.Password)
+		}
+	}
 
 	if err := validation.ValidateInstallConfig(a.Config, false).ToAggregate(); err != nil {
 		if filename == "" {