Use rendezvous-host.env as environment file

Don't source /etc/assisted/rendezvous-host.env in shell script when it
can be used as a systemd EnvironmentFile.

Author: zaneb

data/data/agent/files/usr/local/bin/start-agent.sh

@@ -1,8 +1,5 @@
 #!/bin/bash
 
-# shellcheck disable=SC1091
-source /etc/assisted/rendezvous-host.env
-
 >&2 echo "Waiting for infra-env-id to be available"
 INFRA_ENV_ID=""
 until [[ $INFRA_ENV_ID != "" && $INFRA_ENV_ID != "null" ]]; do

data/data/agent/files/usr/local/bin/start-cluster-installation.sh.template

@@ -3,8 +3,6 @@ set -e
 
 source issue_status.sh
 
-wait-for-assisted-service.sh
-
 BASE_URL="${SERVICE_BASE_URL}api/assisted-install/v2"
 
 cluster_id=""

data/data/agent/files/usr/local/bin/wait-for-assisted-service.sh

@@ -1,9 +1,6 @@
 #!/bin/bash
 set -e
 
-# shellcheck disable=SC1091
-source /etc/assisted/rendezvous-host.env
-
 echo "Waiting for assisted-service to be ready"
 until curl --output /dev/null --silent --fail "${SERVICE_BASE_URL}/api/assisted-install/v2/infra-envs"; do
     printf '.'

data/data/agent/systemd/units/agent.service.template

@@ -4,6 +4,7 @@ Restart=always
 RestartSec=3
 StartLimitInterval=0
 TimeoutStartSec=3000
+EnvironmentFile=/etc/assisted/rendezvous-host.env
 ExecStartPre=/usr/local/bin/extract-agent.sh
 ExecStart=/usr/local/bin/start-agent.sh
 

data/data/agent/systemd/units/start-cluster-installation.service

@@ -8,6 +8,8 @@ ConditionPathExists=/etc/assisted/node0
 
 [Service]
 EnvironmentFile=/usr/local/share/assisted-service/assisted-service.env
+EnvironmentFile=/etc/assisted/rendezvous-host.env
+ExecStartPre=/usr/local/bin/wait-for-assisted-service.sh
 ExecStart=/usr/local/bin/start-cluster-installation.sh
 
 KillMode=none