OCPBUGS-23539: Keep Machine manifests out of OpenShift Manifests asset

IsMachineManifest() should match all of the manifests generated by
either the Master or Worker machines asset. Several new types of files
have been added, particularly for baremetal, without updating this
function. This resulted in the files being matched by the generic
OpenShift Manifests asset as well as the one that actually created them.

Author: zaneb

pkg/asset/machines/master.go

@@ -747,6 +747,21 @@ func IsMachineManifest(file *asset.File) bool {
 	} else if matched {
 		return true
 	}
+	if matched, err := filepath.Match(secretFileNamePattern, filename); err != nil {
+		panic("bad format for secret file name pattern")
+	} else if matched {
+		return true
+	}
+	if matched, err := filepath.Match(networkConfigSecretFileNamePattern, filename); err != nil {
+		panic("bad format for network config secret file name pattern")
+	} else if matched {
+		return true
+	}
+	if matched, err := filepath.Match(hostFileNamePattern, filename); err != nil {
+		panic("bad format for host file name pattern")
+	} else if matched {
+		return true
+	}
 	if matched, err := filepath.Match(masterMachineFileNamePattern, filename); err != nil {
 		panic("bad format for master machine file name pattern")
 	} else if matched {

pkg/asset/machines/master_test.go

@@ -307,6 +307,7 @@ func TestBaremetalGeneratedAssetFiles(t *testing.T) {
 
 	assert.Len(t, master.NetworkConfigSecretFiles, 1)
 	verifySecret(t, master.NetworkConfigSecretFiles[0], "openshift/99_openshift-cluster-api_host-network-config-secrets-0.yaml", "master-0-network-config-secret", "map[nmstate:[105 110 116 101 114 102 97 99 101 115 58 32 110 117 108 108 10]]")
+	verifyManifestOwnership(t, master)
 }
 
 func verifyHost(t *testing.T, a *asset.File, eFilename, eName string) {
@@ -326,6 +327,13 @@ func verifySecret(t *testing.T, a *asset.File, eFilename, eName, eData string) {
 	assert.Equal(t, eData, fmt.Sprintf("%v", secret.Data))
 }
 
+func verifyManifestOwnership(t *testing.T, a asset.WritableAsset) {
+	t.Helper()
+	for _, file := range a.Files() {
+		assert.True(t, IsMachineManifest(file), file.Filename)
+	}
+}
+
 func networkConfig(config string) *v1.JSON {
 	var nc v1.JSON
 	yaml.Unmarshal([]byte(config), &nc)