Remove wait_for_assisted_service from common.sh

We already have a script (that needs to be called from ExecStartPre) to
wait for assisted-service, so move the implementation into there.

Author: zaneb

data/data/agent/files/usr/local/bin/common.sh

@@ -3,14 +3,6 @@
 # shellcheck disable=SC1091
 source /etc/assisted/rendezvous-host.env
 
-wait_for_assisted_service() {
-    echo "Waiting for assisted-service to be ready"
-    until curl --output /dev/null --silent --fail "${SERVICE_BASE_URL}/api/assisted-install/v2/infra-envs"; do
-        printf '.'
-        sleep 5
-    done
-}
-
 is_node_zero() {
     local is_rendezvous_host
     is_rendezvous_host=$(ip -j address | jq "[.[].addr_info] | flatten | map(.local==\"$NODE_ZERO_IP\") | any")

data/data/agent/files/usr/local/bin/start-cluster-installation.sh.template

@@ -1,10 +1,9 @@
 #!/bin/bash
 set -e
 
-source common.sh
 source issue_status.sh
 
-wait_for_assisted_service
+wait-for-assisted-service.sh
 
 BASE_URL="${SERVICE_BASE_URL}api/assisted-install/v2"
 

data/data/agent/files/usr/local/bin/wait-for-assisted-service.sh

@@ -2,6 +2,10 @@
 set -e
 
 # shellcheck disable=SC1091
-source common.sh
+source /etc/assisted/rendezvous-host.env
 
-wait_for_assisted_service
+echo "Waiting for assisted-service to be ready"
+until curl --output /dev/null --silent --fail "${SERVICE_BASE_URL}/api/assisted-install/v2/infra-envs"; do
+    printf '.'
+    sleep 5
+done