Create API and Ingress ports and attach FIPs when available

Author: mandre

pkg/infrastructure/openstack/clusterapi/clusterapi.go

@@ -7,6 +7,9 @@ import (
 	capo "sigs.k8s.io/cluster-api-provider-openstack/api/v1alpha7"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 
+	"github.com/gophercloud/gophercloud"
+	"github.com/gophercloud/gophercloud/openstack/networking/v2/extensions/attributestags"
+	"github.com/gophercloud/gophercloud/openstack/networking/v2/extensions/layer3/floatingips"
 	"github.com/gophercloud/gophercloud/openstack/networking/v2/ports"
 	"github.com/openshift/installer/pkg/asset/manifests/capiutils"
 	"github.com/openshift/installer/pkg/infrastructure/clusterapi"
@@ -37,20 +40,77 @@ func (p Provider) ControlPlaneAvailable(in clusterapi.ControlPlaneAvailableInput
 		return err
 	}
 
-	createOtps := ports.CreateOpts{
-		Name:      "CAPO test",
-		NetworkID: ospCluster.Status.Network.ID,
+	apiPort, err := createPort(networkClient, "api", in.InfraID, ospCluster.Status.Network.ID)
+	if err != nil {
+		return err
+	}
+	if in.InstallConfig.Config.OpenStack.APIFloatingIP != "" {
+		err = assignFIP(networkClient, in.InstallConfig.Config.OpenStack.APIFloatingIP, apiPort)
+		if err != nil {
+			return err
+		}
 	}
 
-	_, err = ports.Create(networkClient, createOtps).Extract()
+	ingressPort, err := createPort(networkClient, "ingress", in.InfraID, ospCluster.Status.Network.ID)
 	if err != nil {
 		return err
 	}
+	if in.InstallConfig.Config.OpenStack.IngressFloatingIP != "" {
+		err = assignFIP(networkClient, in.InstallConfig.Config.OpenStack.IngressFloatingIP, ingressPort)
+		if err != nil {
+			return err
+		}
+	}
+
+	return nil
+}
 
-	_, err = ports.Create(networkClient, createOtps).Extract()
+func createPort(client *gophercloud.ServiceClient, role, infraID, networkID string) (*ports.Port, error) {
+	createOtps := ports.CreateOpts{
+		Name:        fmt.Sprintf("%s-%s-port", infraID, role),
+		NetworkID:   networkID,
+		Description: "Created By OpenShift Installer",
+	}
+
+	port, err := ports.Create(client, createOtps).Extract()
 	if err != nil {
-		return err
+		return nil, err
 	}
 
+	tag := fmt.Sprintf("openshiftClusterID=%s", infraID)
+	err = attributestags.Add(client, "ports", port.ID, tag).ExtractErr()
+	if err != nil {
+		return nil, err
+	}
+	return port, err
+}
+
+func assignFIP(client *gophercloud.ServiceClient, address string, port *ports.Port) error {
+	listOpts := floatingips.ListOpts{
+		FloatingIP: address,
+	}
+	allPages, err := floatingips.List(client, listOpts).AllPages()
+	if err != nil {
+		return fmt.Errorf("failed to list floating IPs: %w", err)
+	}
+	allFIPs, err := floatingips.ExtractFloatingIPs(allPages)
+	if err != nil {
+		return fmt.Errorf("failed to extract floating IPs: %w", err)
+	}
+
+	if len(allFIPs) != 1 {
+		return fmt.Errorf("could not find FIP: %s", address)
+	}
+
+	fip := allFIPs[0]
+
+	updateOpts := floatingips.UpdateOpts{
+		PortID: &port.ID,
+	}
+
+	_, err = floatingips.Update(client, fip.ID, updateOpts).Extract()
+	if err != nil {
+		return fmt.Errorf("failed to attach floating IP to port: %w", err)
+	}
 	return nil
 }