Skip to content

Commit 792a0cf

Browse files
gryfMaysaMacedo
authored andcommitted
OpenStack: Determine dualstack installation by value
Check os_subnet6 instead of os_subnet6_range to determine dual-stack installation in UPI playbooks.
1 parent 3de486e commit 792a0cf

File tree

6 files changed

+14
-26
lines changed

6 files changed

+14
-26
lines changed

upi/openstack/bootstrap.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
- "{{ os_sg_master }}"
2020
allowed_address_pairs:
2121
- ip_address: "{{ os_apiVIP }}"
22-
when: os_subnet6_range is not defined
22+
when: os_subnet6 is not defined
2323

2424
- name: 'Create the bootstrap dualstack server port'
2525
os_port:
@@ -30,7 +30,7 @@
3030
allowed_address_pairs:
3131
- ip_address: "{{ os_apiVIP }}"
3232
- ip_address: "{{ os_apiVIP6 }}"
33-
when: os_subnet6_range is defined
33+
when: os_subnet6 is defined
3434

3535
- name: 'Set bootstrap port tag'
3636
command:

upi/openstack/compute-nodes.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
- ip_address: "{{ os_ingressVIP }}"
2222
with_indexed_items: "{{ [os_port_worker] * os_compute_nodes_number }}"
2323
register: ports
24-
when: os_subnet6_range is not defined
24+
when: os_subnet6 is not defined
2525

2626
- name: 'Create the dualstack Compute ports'
2727
openstack.cloud.port:
@@ -34,7 +34,7 @@
3434
- ip_address: "{{ os_ingressVIP6 }}"
3535
with_indexed_items: "{{ [os_port_worker] * os_compute_nodes_number }}"
3636
register: ports
37-
when: os_subnet6_range is defined
37+
when: os_subnet6 is defined
3838

3939
- name: 'Set Compute ports tag'
4040
ansible.builtin.command:

upi/openstack/control-plane.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
- ip_address: "{{ os_ingressVIP }}"
2323
with_indexed_items: "{{ [os_port_master] * os_cp_nodes_number }}"
2424
register: ports
25-
when: os_subnet6_range is not defined
25+
when: os_subnet6 is not defined
2626

2727
- name: 'Create the dualstack Control Plane ports'
2828
openstack.cloud.port:
@@ -37,7 +37,7 @@
3737
- ip_address: "{{ os_ingressVIP6 }}"
3838
with_indexed_items: "{{ [os_port_master] * os_cp_nodes_number }}"
3939
register: ports
40-
when: os_subnet6_range is defined
40+
when: os_subnet6 is defined
4141

4242
- name: 'Set Control Plane ports tag'
4343
ansible.builtin.command:

upi/openstack/network.yaml

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,7 @@
3030
ip_version: 6
3131
ipv6_address_mode: "{{ os_subnet6_address_mode }}"
3232
ipv6_ra_mode: "{{ os_subnet6_router_advertisements_mode }}"
33-
when:
34-
- os_subnet6_range is defined
35-
- os_subnet6_range|ansible.utils.ipv6
33+
when: os_subnet6 is defined
3634

3735
- name: 'Create external router'
3836
openstack.cloud.router:
@@ -49,8 +47,7 @@
4947
- "{{ os_subnet }}"
5048
- "{{ os_subnet6 }}"
5149
when:
52-
- os_subnet6_range is defined
53-
- os_subnet6_range|ansible.utils.ipv6
50+
- os_subnet6 is defined
5451
- os_external_network is defined and os_external_network|length>0
5552

5653
- name: 'Create the API port'
@@ -61,8 +58,7 @@
6158
- subnet: "{{ os_subnet }}"
6259
ip_address: "{{ os_apiVIP }}"
6360
register: _api_ports
64-
when:
65-
- os_subnet6_range is not defined
61+
when: os_subnet6 is not defined
6662

6763
- set_fact:
6864
api_ports: "{{ _api_ports }}"
@@ -73,9 +69,7 @@
7369
name: "{{ os_port_api }}"
7470
network: "{{ os_network }}"
7571
register: _api_ports
76-
when:
77-
- os_subnet6_range is defined
78-
- os_subnet6_range|ansible.utils.ipv6
72+
when: os_subnet6 is defined
7973

8074
- set_fact:
8175
api_ports: "{{ _api_ports }}"
@@ -89,8 +83,7 @@
8983
- subnet: "{{ os_subnet }}"
9084
ip_address: "{{ os_ingressVIP }}"
9185
register: _ingress_ports
92-
when:
93-
- os_subnet6_range is not defined
86+
when: os_subnet6 is not defined
9487

9588
- set_fact:
9689
ingress_ports: "{{ _ingress_ports }}"
@@ -101,9 +94,7 @@
10194
name: "{{ os_port_ingress }}"
10295
network: "{{ os_network }}"
10396
register: _ingress_ports
104-
when:
105-
- os_subnet6_range is defined
106-
- os_subnet6_range|ansible.utils.ipv6
97+
when: os_subnet6 is defined
10798

10899
- set_fact:
109100
ingress_ports: "{{ _ingress_ports }}"

upi/openstack/security-groups.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -373,5 +373,4 @@
373373
when: os_master_schedulable is defined and os_master_schedulable
374374

375375
when:
376-
- os_subnet6_range is defined
377-
- os_subnet6_range|ansible.utils.ipv6
376+
when: os_subnet6 is defined

upi/openstack/update-network-resources.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,7 @@
2222
- name: 'Set tags on primary cluster subnet IPv6'
2323
ansible.builtin.command:
2424
cmd: "openstack subnet set --tag {{ cluster_id_tag }} {{ os_subnet6 }}"
25-
when:
26-
- os_subnet6_range is defined
27-
- os_subnet6_range|ansible.utils.ipv6
25+
when: os_subnet6 is defined
2826

2927
- name: 'Set tags on the API VIP port'
3028
ansible.builtin.command:

0 commit comments

Comments
 (0)