pkg/infra/clusterapi: add BootstrapHasPublicIP

Adds a method to the cluster-api-provider interface to indicate
whether a platform expects its bootstrap node to have a public
IP address in a public cluster. We can use this value to determine
whether the external IP should be waited for during the machine
ready checks. This ensures that the external IP will be populated
if it is needed for gather bootstrap.

Author: patrickdillon

pkg/infrastructure/aws/clusterapi/aws.go

@@ -39,6 +39,10 @@ type Provider struct{}
 // Name gives the name of the provider, AWS.
 func (*Provider) Name() string { return awstypes.Name }
 
+// BootstrapHasPublicIP indicates that machine ready checks
+// should wait for an ExternalIP in the status.
+func (*Provider) BootstrapHasPublicIP() bool { return true }
+
 // PreProvision creates the IAM roles used by all nodes in the cluster.
 func (*Provider) PreProvision(ctx context.Context, in clusterapi.PreProvisionInput) error {
 	if err := createIAMRoles(ctx, in.InfraID, in.InstallConfig); err != nil {

pkg/infrastructure/azure/azure.go

@@ -51,6 +51,10 @@ func (p *Provider) Name() string {
 	return aztypes.Name
 }
 
+// BootstrapHasPublicIP indicates that an ExternalIP is not
+// required in the machine ready checks.
+func (*Provider) BootstrapHasPublicIP() bool { return false }
+
 // PreProvision is called before provisioning using CAPI controllers has begun.
 func (p *Provider) PreProvision(ctx context.Context, in clusterapi.PreProvisionInput) error {
 	session, err := in.InstallConfig.Azure.Session()

pkg/infrastructure/clusterapi/types.go

@@ -18,6 +18,12 @@ import (
 type Provider interface {
 	// Name provides the name for the cloud platform.
 	Name() string
+
+	// BootstrapHasPublicIP indicates whether a public IP address
+	// is expected on the bootstrap node in a public cluster.
+	// When BootstrapHasPublicIP returns true, the machine ready checks
+	// wait for an ExternalIP address to be populated in the machine status.
+	BootstrapHasPublicIP() bool
 }
 
 // PreProvider defines the PreProvision hook, which is called prior to

pkg/infrastructure/gcp/clusterapi/clusterapi.go

@@ -37,6 +37,10 @@ func (p Provider) Name() string {
 	return gcptypes.Name
 }
 
+// BootstrapHasPublicIP indicates that machine ready checks
+// should wait for an ExternalIP in the status.
+func (Provider) BootstrapHasPublicIP() bool { return true }
+
 // PreProvision is called before provisioning using CAPI controllers has initiated.
 // GCP resources that are not created by CAPG (and are required for other stages of the install) are
 // created here using the gcp sdk.

pkg/infrastructure/ibmcloud/clusterapi/clusterapi.go

@@ -18,6 +18,10 @@ func (p Provider) Name() string {
 	return ibmcloudtypes.Name
 }
 
+// BootstrapHasPublicIP indicates that an ExternalIP is not
+// required in the machine ready checks.
+func (Provider) BootstrapHasPublicIP() bool { return false }
+
 // PreProvision creates the IBM Cloud objects required prior to running capibmcloud.
 func (p Provider) PreProvision(ctx context.Context, in clusterapi.PreProvisionInput) error {
 	return nil

pkg/infrastructure/nutanix/clusterapi/clusterapi.go

@@ -23,6 +23,10 @@ func (p Provider) Name() string {
 	return nutanixtypes.Name
 }
 
+// BootstrapHasPublicIP indicates that an ExternalIP is not
+// required in the machine ready checks.
+func (Provider) BootstrapHasPublicIP() bool { return false }
+
 // PreProvision creates the resources required prior to running capi nutanix controller.
 func (p Provider) PreProvision(ctx context.Context, in infracapi.PreProvisionInput) error {
 	// create categories with name "kubernetes-io-cluster-<cluster_id>" and values ["owned", "shared"].

pkg/infrastructure/openstack/clusterapi/clusterapi.go

@@ -31,6 +31,10 @@ func (p Provider) Name() string {
 	return openstack.Name
 }
 
+// BootstrapHasPublicIP indicates that an ExternalIP is not
+// required in the machine ready checks.
+func (Provider) BootstrapHasPublicIP() bool { return false }
+
 var _ clusterapi.PreProvider = Provider{}
 
 // PreProvision tags the VIP ports, and creates the security groups and the

pkg/infrastructure/powervs/clusterapi/powervs.go

@@ -38,6 +38,10 @@ func (p Provider) Name() string {
 	return powervstypes.Name
 }
 
+// BootstrapHasPublicIP indicates that an ExternalIP is not
+// required in the machine ready checks.
+func (Provider) BootstrapHasPublicIP() bool { return false }
+
 func leftInContext(ctx context.Context) time.Duration {
 	deadline, ok := ctx.Deadline()
 	if !ok {

pkg/infrastructure/vsphere/clusterapi/clusterapi.go

@@ -27,6 +27,10 @@ func (p Provider) Name() string {
 	return vsphere.Name
 }
 
+// BootstrapHasPublicIP indicates that an ExternalIP is not
+// required in the machine ready checks.
+func (Provider) BootstrapHasPublicIP() bool { return false }
+
 func initializeFoldersAndTemplates(ctx context.Context, cachedImage string, failureDomain vsphere.FailureDomain, session *session.Session, diskType vsphere.DiskType, clusterID, tagID string) error {
 	finder := session.Finder